From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jens Schmidt via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63949: 30.0.50; =?UTF-8?Q?`vc-print-log=C2=B4?= does not erase buffer when called from *vc-change-log* buffer, at least for CVS logs Date: Fri, 9 Jun 2023 22:27:37 +0200 Message-ID: <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> Reply-To: Jens Schmidt Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14109"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Cc: 63949@debbugs.gnu.org, manuel@ledu-giraud.fr To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 09 22:28:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7iiW-0003X4-Pc for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Jun 2023 22:28:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q7iiJ-0002FH-VN; Fri, 09 Jun 2023 16:28:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7iiI-0002Eo-Bm for bug-gnu-emacs@gnu.org; Fri, 09 Jun 2023 16:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q7iiH-0002Nm-Ty for bug-gnu-emacs@gnu.org; Fri, 09 Jun 2023 16:28:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q7iiH-0007Ug-NO for bug-gnu-emacs@gnu.org; Fri, 09 Jun 2023 16:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jens Schmidt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Jun 2023 20:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63949 X-GNU-PR-Package: emacs Original-Received: via spool by 63949-submit@debbugs.gnu.org id=B63949.168634247828797 (code B ref 63949); Fri, 09 Jun 2023 20:28:01 +0000 Original-Received: (at 63949) by debbugs.gnu.org; 9 Jun 2023 20:27:58 +0000 Original-Received: from localhost ([127.0.0.1]:60986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7iiE-0007UP-FE for submit@debbugs.gnu.org; Fri, 09 Jun 2023 16:27:58 -0400 Original-Received: from mr4.vodafonemail.de ([145.253.228.164]:36910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7iiC-0007UB-MW for 63949@debbugs.gnu.org; Fri, 09 Jun 2023 16:27:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1686342471; bh=ieZ38042yCBbFfQeWAQpILW78lmrNgrXOwJciBOG78A=; h=Message-ID:Date:User-Agent:Subject:Content-Language:To:References: From:In-Reply-To:Content-Type:From; b=i4vWVFwjedGwe0BHfX4ngArlzMJUjQVje6UujaIUxd5zV0W3RndfMIho3YYGXxsQH 7G0nS2kwJ4wP8sh098V9Bjq7x1GZvgTjV6O60tyJihiFU4BSCdtvGxlf/5ytCEok3G LzNoJTXubOz9VEPQ4Ta0hcEWQiJ9XAITbGe4b6Dk= Original-Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr4.vodafonemail.de (Postfix) with ESMTPS id 4QdCLv2z2jz1y9V; Fri, 9 Jun 2023 20:27:51 +0000 (UTC) Original-Received: from [192.168.178.41] (port-92-194-25-231.dynamic.as20676.net [92.194.25.231]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4QdCLh6bgxzMm7G; Fri, 9 Jun 2023 20:27:37 +0000 (UTC) Content-Language: de-DE-frami, en-US In-Reply-To: <83y1kt180v.fsf@gnu.org> X-purgate-type: clean X-purgate: clean X-purgate-size: 1324 X-purgate-ID: 155817::1686342467-7FFFE4B9-48ECDA2B/0/0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263188 Archived-At: On 2023-06-09 08:09, Eli Zaretskii wrote: > What do you mean by "modifies the VC parent buffer to itself"? Do > you mean that vc-print-log makes the *vc-change-buffer* be the VC > parent buffer? If so, why is this incorrect? Hope below recipe explains it. The general idea is to start a VC command first from the buffer of a VC-controlled file, then from the VC result buffer, again from the VC result buffer, etc. emacs -Q (from emacs-29) ;; current buffer equals README C-x v l ;; current buffer equals *vc-change-log* C-h v vc-parent-buffer => # ;; current buffer equals *vc-change-log* C-x v l C-h v vc-parent-buffer => # ;; current buffer equals *vc-change-log* C-x v l ;; git log of whole repository is displayed, not of README I backed out commit d494833d47968fcd97ba549654a259d6fb6c2eee from emacs-29 - both issues (the initial CVS-related one and the above one) are gone after having done so. Not all VC commands expose this problem. `vc-annotate' seems to work and even the VC parent buffer stays unchanged when invoking `vc-annotate' repeatedly. `vc-diff' gets the parent buffer wrong but seems to work when invoked from buffer *vc-diff* repeatedly even if parent buffer is wrong.