From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Fri, 18 Oct 2019 17:25:20 +0300 Message-ID: <8462e4a8-c6a8-9cd7-60ff-3bd944d0b6b6@yandex.ru> References: <83bluhf7nz.fsf@gnu.org> <20191016111004.oialbyleokafpccz@Ergus> <87k194fvn7.fsf@mail.linkov.net> <871rvceeqp.fsf@mail.linkov.net> <83tv88cyic.fsf@gnu.org> <83pniwcvon.fsf@gnu.org> <87pniw30td.fsf@mail.linkov.net> <4dc05091-53db-bff9-4623-0aedd9c2907f@gmx.at> <6f01b03d-7be3-71cc-ff97-c1a4f7b3c213@yandex.ru> <83tv879vy0.fsf@gnu.org> <6bc27f9f-e701-afb8-c6f1-408f471187c7@yandex.ru> <83imon9tg3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="27886"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 Cc: 37774@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 18 16:26:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iLTCu-00078R-0V for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Oct 2019 16:26:20 +0200 Original-Received: from localhost ([::1]:40874 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLTCs-0003dw-Ly for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Oct 2019 10:26:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60923) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLTCd-0003dR-P1 for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2019 10:26:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLTCc-0000LH-Cf for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2019 10:26:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42522) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iLTCc-0000KR-98 for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2019 10:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iLTCc-00082D-0K for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2019 10:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Oct 2019 14:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157140873330839 (code B ref 37774); Fri, 18 Oct 2019 14:26:01 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 18 Oct 2019 14:25:33 +0000 Original-Received: from localhost ([127.0.0.1]:51342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iLTC7-00081J-1R for submit@debbugs.gnu.org; Fri, 18 Oct 2019 10:25:33 -0400 Original-Received: from mail-wm1-f48.google.com ([209.85.128.48]:55554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iLTC4-000811-Lq for 37774@debbugs.gnu.org; Fri, 18 Oct 2019 10:25:29 -0400 Original-Received: by mail-wm1-f48.google.com with SMTP id a6so6384624wma.5 for <37774@debbugs.gnu.org>; Fri, 18 Oct 2019 07:25:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nSpmFaBFhO18QbuY6mBhgR0EAmH154qZBqonfLJsPas=; b=tVyx63EH6PmcdgtfwRBW5VlZHEcAC7lfT+Zmrr1knzKYG9Td/aD7oes6mEKD2C+YAQ XhMNxpxOjv4/ubuwH9F9v2c3hHWEsGkL8wXwTdBLSpF9+EVoVncorEDQAL129wjIaOMi 0850zjDSx+HSHkrPasIbmNVuYCMtOGVr1yhRlN9P3cAWOWdlkG1vZA4VSzXAChgxUbqE 7YkWE8RR07RVOxbJUYQ5ao2thXzaUV4RiPzU+ZgbI0jJRtTJ3rvFk1nNtvzb5BF6nCpO 2V8FPVxBtEwdineLK5BEbzd6jcYpWzIu9fl2QCDrGKpgVO9xgK1EWDc16TCEBgLGc6oN 8AhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nSpmFaBFhO18QbuY6mBhgR0EAmH154qZBqonfLJsPas=; b=pyggP/HfaM4kXu2SqeGKFjPP5wWAyTYPktGWG087BaEX9fykEu4uTjAMHAVNzR3zzd +jbKnJbJzHqESCaPlsiFdfclWQtjrLjojtrkLbMp3+GA4SuvOSbYudXQcN0dgcavSg66 V0agpGKFhZfR/3xU/l35TImXliqSFcrkIVFzvIVbekGg+YsqTh2GHScwTtYw3/4umIpe 3BWP7JbDohtFJGnPuDWNMsnwyvubCcatzdDULVVG0LHCYo0QZMrKpp9/IeDT/Dbhr8sM 612BoAfSe5zAFfFx+Mjplo4tymBpq/2BJ19JrOu4/h3/O2EDhu+tYb/Nace+4S8Urhv4 8wUw== X-Gm-Message-State: APjAAAU7Lrf8eJG5h1K14xNI4eCjtKmmWDiuLDuAOnx7qoJnub14HMtj NtosngTVielydQQTy8RjUdo/sYYV X-Google-Smtp-Source: APXvYqzecHmitaYhy0jk7QxSigVzyTnxBZ6NQLaINfpPrq1lZMM30cEZGV+OGezcgRsXpXYCtLn90g== X-Received: by 2002:a05:600c:21c8:: with SMTP id x8mr7253014wmj.123.1571408722425; Fri, 18 Oct 2019 07:25:22 -0700 (PDT) Original-Received: from [192.168.0.140] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id s9sm6360182wme.36.2019.10.18.07.25.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Oct 2019 07:25:21 -0700 (PDT) In-Reply-To: <83imon9tg3.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169665 Archived-At: On 17.10.2019 20:23, Eli Zaretskii wrote: >> After considering it a bit, I might like Firefox-like behavior for the >> region personally. > > That's what happened to me as well. So I think people who are > claiming it's a breaking change might try running with the change for > a week or so, perhaps they will change their minds. FWIW my friend is adamant in his dislike, however. I'm sure there will be others. But that's of no import, considering we'll make sure the 'region' face has the :extend property set to t even when a third-party theme is used, right? >> Even so, it might be safer to only offer such option and not change >> it by default. > > We did, for the 'region' face. Speaking of... it might be just my opinion, but it feels like whether a face background should extend to the edge of the screen is more of a structural quality, like a personal choice, and not something that themes (being color palettes) should define or redefine. So maybe I would pick a different mechanism instead of a face attribute. E.g. just a property on the face's symbol name. Then it won't be affected by custom-set-faces either way. Or another idea: split it into extend-foreground and extend-background. As someone remarked in this thread already, extend-foreground can safely default to nil, and we can set extend-background to t by default, for maximum backward compatibility. >> This example was about how diff-mode behavior did/should look, though. > > We could consider individual faces for making them extend by default. > But there's a more general claim in this bug report: that the change > will screw many unbundled packages out there; if that is true, > changing some faces in core is not a solution. Magit and Org will probably take the brunt of the change.