From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#24977: 25.1; search and query-replace in Dired Date: Mon, 21 Nov 2016 08:36:55 -0800 (PST) Message-ID: <845ed24d-8693-4691-aaaf-8f5b427a1563@default> References: <> <<83h97094yh.fsf@gnu.org>> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1479746299 26989 195.159.176.226 (21 Nov 2016 16:38:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 21 Nov 2016 16:38:19 +0000 (UTC) Cc: 24977-done@debbugs.gnu.org To: Eli Zaretskii , Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 21 17:38:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c8rbf-0005z0-Kh for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Nov 2016 17:38:11 +0100 Original-Received: from localhost ([::1]:50482 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c8rbj-00051t-7H for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Nov 2016 11:38:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c8rbZ-00051Z-FO for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2016 11:38:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c8rbW-0001pE-BL for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2016 11:38:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50121) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c8rbW-0001pA-7j for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2016 11:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c8rbV-0006Xp-VW for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2016 11:38:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Nov 2016 16:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24977 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24977-done@debbugs.gnu.org id=D24977.147974622625090 (code D ref 24977); Mon, 21 Nov 2016 16:38:01 +0000 Original-Received: (at 24977-done) by debbugs.gnu.org; 21 Nov 2016 16:37:06 +0000 Original-Received: from localhost ([127.0.0.1]:37286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c8rac-0006Wc-9Q for submit@debbugs.gnu.org; Mon, 21 Nov 2016 11:37:06 -0500 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:41511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c8raa-0006W7-9o for 24977-done@debbugs.gnu.org; Mon, 21 Nov 2016 11:37:04 -0500 Original-Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id uALGav6E002965 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 Nov 2016 16:36:58 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id uALGav6b022107 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 Nov 2016 16:36:57 GMT Original-Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id uALGavS6022880; Mon, 21 Nov 2016 16:36:57 GMT In-Reply-To: <<83h97094yh.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6753.5000 (x86)] X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125947 Archived-At: > > However, you did NOT change the menu bindings for `dired-do- > > search' and `dired-do-query-replace-regexp' (the commands formerly > > bound to `A' and `Q'). This is inconsistent. Those menu items no > > longer show the keyboard shortcuts, because they have none. And > > the new commands are not on menus at all. >=20 > Thanks, I fixed that now. >=20 > > It was unwise to change the key bindings. They should be > > restored, and new bindings should be sought for your new commands. >=20 > Let's not start beating this dead horse again. Then you did NOT fix this bug, and it should be closed as `wont fix'. That's your choice, but please do not claim that you fixed the bug that was reported if you did not. The original search and query-replace commands, which were in the menu, should also have keyboard key bindings (as before). AND the new commands should be added to the menu. For the menu, I suggest: `Search Files' - as before `Search Files using `find' - for the new command `Query Replace' - as before `Query Replace using `find' - for the new command Logically, the longstanding key bindings `A' and `Q' should be restored to the original commands. But if you refuse that then they should at least be given other key bindings - `M-a' and `M-q', for example. Doing this, you can rightfully close this bug as fixed. Otherwise, no.