From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#3984: 23.0.96; defadvice of call-interactively defeats interactive-p Date: Tue, 11 Oct 2011 07:26:39 -0700 Message-ID: <843EB599BB3E431F8543D33410200715@us.oracle.com> References: <20E00C7675E64356BF2F0B2A7E0ABDB1@us.oracle.com> <7iaa99o07h.fsf@mack.tetzco.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1318343282 31552 80.91.229.12 (11 Oct 2011 14:28:02 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 11 Oct 2011 14:28:02 +0000 (UTC) To: "'Kai Tetzlaff'" , <3984@debbugs.gnu.org> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 11 16:27:58 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RDdJG-0004Br-8n for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Oct 2011 16:27:58 +0200 Original-Received: from localhost ([::1]:38270 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDdJD-0004E5-Ji for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Oct 2011 10:27:55 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:32991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDdJ8-0004Dy-Fk for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2011 10:27:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RDdJ2-00065B-Gp for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2011 10:27:50 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57070) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDdJ2-00064m-Du for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2011 10:27:44 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RDdJJ-0007lU-I4 for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2011 10:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Oct 2011 14:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 3984 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 3984-submit@debbugs.gnu.org id=B3984.131834323729797 (code B ref 3984); Tue, 11 Oct 2011 14:28:01 +0000 Original-Received: (at 3984) by debbugs.gnu.org; 11 Oct 2011 14:27:17 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDdIa-0007kX-Sf for submit@debbugs.gnu.org; Tue, 11 Oct 2011 10:27:17 -0400 Original-Received: from rcsinet15.oracle.com ([148.87.113.117]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDdIZ-0007kJ-4u for 3984@debbugs.gnu.org; Tue, 11 Oct 2011 10:27:16 -0400 Original-Received: from ucsinet24.oracle.com (ucsinet24.oracle.com [156.151.31.67]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p9BEQoRf014941 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 11 Oct 2011 14:26:52 GMT Original-Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet24.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p9BEKstN000502 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 11 Oct 2011 14:20:55 GMT Original-Received: from abhmt103.oracle.com (abhmt103.oracle.com [141.146.116.55]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p9BEQiUd009636; Tue, 11 Oct 2011 09:26:44 -0500 Original-Received: from dradamslap1 (/10.159.50.234) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 11 Oct 2011 07:26:44 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <7iaa99o07h.fsf@mack.tetzco.de> Thread-Index: AcyHG+ozyPc8RkJjQvuH7BtrpN4iPgBBQlFw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: ucsinet24.oracle.com [156.151.31.67] X-CT-RefId: str=0001.0A090208.4E94522C.00A1,ss=1,re=0.000,fgs=0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 11 Oct 2011 10:28:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:52523 Archived-At: > From: Kai Tetzlaff Sent: Sunday, October 09, 2011 11:00 PM > > I'm using icicles and just ran into this bug with emacs compiled from > bzr. The function count-words-region has been changed to use > called-interactively-p to check for interactive use. As reported, the > check fails when icicles is turned on. As there are >300 places under > the emacs lisp/ directory alone which use called-interactively-p, it > would really be great, if it could be made more robust. For info, this is the defadvice that exposes the `called-interactively' bug (#3984): (defadvice call-interactively (after icicle-save-to-history disable activate) "Save command to `icicle-interactive-history'." ;; If command's input is not a parameterized (e.g. mouse) ;; event, record it. (let* ((fn (ad-get-arg 0)) (int (interactive-form fn))) (when (and (symbolp fn) (consp int) (or (not (stringp (cadr int))) (string= (cadr int) "") (not (eq ?e (aref (cadr int) 0))))) (pushnew (symbol-name fn) icicle-interactive-history)))) This behavior is optional, so Icicles users can turn it off (it is off by default) via option `icicle-populate-interactive-history-flag'. And the doc string of that option refers to Emacs bug #3948. Still, it would be good to get this Emacs bug fixed - especially, as Kai remarks, since the Emacs source code now uses `called-interactively-p' all over the place.