From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andrea Rossetti Newsgroups: gmane.emacs.bugs Subject: bug#17788: 24.3; ruler-mode: column indicators "hop" left if you drag them diagonally Date: Wed, 18 Jun 2014 01:50:33 +0200 Message-ID: <841tunnliu.fsf@gmail.com> References: <84ppiahtix.fsf@gmail.com> <87fvj5omej.fsf@rosalinde.fritz.box> <84zjhdixgw.fsf@gmail.com> <539E9891.8020507@gmx.at> <847g4gd2in.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1403049088 4396 80.91.229.3 (17 Jun 2014 23:51:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 17 Jun 2014 23:51:28 +0000 (UTC) To: 17788@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 18 01:51:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wx39s-0003hO-Ts for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Jun 2014 01:51:21 +0200 Original-Received: from localhost ([::1]:54214 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wx39s-0007u4-Bw for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Jun 2014 19:51:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53975) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wx39i-0007sy-4O for bug-gnu-emacs@gnu.org; Tue, 17 Jun 2014 19:51:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wx39a-0006f9-F9 for bug-gnu-emacs@gnu.org; Tue, 17 Jun 2014 19:51:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wx39a-0006f5-CA for bug-gnu-emacs@gnu.org; Tue, 17 Jun 2014 19:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Wx39Z-00057N-TO for bug-gnu-emacs@gnu.org; Tue, 17 Jun 2014 19:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Rossetti Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Jun 2014 23:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17788 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17788-submit@debbugs.gnu.org id=B17788.140304904619647 (code B ref 17788); Tue, 17 Jun 2014 23:51:01 +0000 Original-Received: (at 17788) by debbugs.gnu.org; 17 Jun 2014 23:50:46 +0000 Original-Received: from localhost ([127.0.0.1]:51000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wx39J-00056p-RQ for submit@debbugs.gnu.org; Tue, 17 Jun 2014 19:50:46 -0400 Original-Received: from mail-wg0-f43.google.com ([74.125.82.43]:59231) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wx39G-00056Z-M5 for 17788@debbugs.gnu.org; Tue, 17 Jun 2014 19:50:43 -0400 Original-Received: by mail-wg0-f43.google.com with SMTP id b13so61416wgh.14 for <17788@debbugs.gnu.org>; Tue, 17 Jun 2014 16:50:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=D01RXh0lEIH5XOxj5qnTdOzVGMHhjUFHaTJzYQY1xwU=; b=z52MPaeiVXCMrguo1qhebxn+/AlnS+dbGNDn34k9cuOgADbEKqiAUv6UvV3nmIVkbR N48t5A+8ydZBeWdoZ6BulLQvyLz7qzOtltLc2u+Rstbyaj7Mqi6F7yxYUzQWAK7U5cal 19pW1S2az/DjnSYX5JxTnvLkpikEKKpW+sZNxylaT14xezuw2XrnBZgnGsxU2xDFlQyI PZpf+rq1uDuANMvNHKocc9oTJEcNa7ACiDbWdsxGN1v97jn7y7Ta2K3C+USCczFLpDZO AA37rf16KPnp4Y7Dd/oXF4qyiFm31/l9Dkv+zGjt8vXuZRSfLLYhQjcceXwshlJDbxZw 3FWw== X-Received: by 10.180.19.233 with SMTP id i9mr285365wie.38.1403049036512; Tue, 17 Jun 2014 16:50:36 -0700 (PDT) Original-Received: from LAPTOP-ANDREA.laptop-andrea.trieste.it (net-93-144-105-178.cust.dsl.teletu.it. [93.144.105.178]) by mx.google.com with ESMTPSA id o47sm1255968eeg.8.2014.06.17.16.50.34 for <17788@debbugs.gnu.org> (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 17 Jun 2014 16:50:35 -0700 (PDT) In-Reply-To: <847g4gd2in.fsf@gmail.com> (Andrea Rossetti's message of "Mon, 16 Jun 2014 22:26:40 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (windows-nt) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:90491 Archived-At: Andrea Rossetti writes: > > The new tentative patch is attached here below: > .... > +(defsubst ruler-mode-window-col (start-or-end-event) > .... > + (- (car (posn-col-row start-or-end-event)) > + (if (eq (posn-area start-or-end-event) 'header-line) > + (+ > + (or (car (window-margins)) 0) > + (fringe-columns 'left) > + (scroll-bar-columns 'left)) > + 0))) Some additional word of comment: - I believe the implicit meaning of the above code is "(car (posn-col-row ...)) is fine in text area, but needs to be `adjusted' when the drag is performed in header-line area"; - whether this adjustment should really be performed by posn-col-row or by ruler-mode-window-col is not very clear to me; I conjectured that subr.el provides somewhat `lower-level' service functions who probably don't want to know about window-margins, fringe-columns, scroll-bar-columns, but I might be wrong; - be aware that dragging the column indicators does not work if you use non-zero zoom (C-x C-+ or C-x C--); this is an independent problem that the patch does not address; the issue would need his own bug report. Thanks for reading, kindest regards. Andrea