From: Drew Adams <drew.adams@oracle.com>
To: 36501@debbugs.gnu.org
Subject: bug#36501: 26.2; (elisp) `Defining Minor Modes'
Date: Thu, 4 Jul 2019 08:33:07 -0700 (PDT) [thread overview]
Message-ID: <840640b2-bc37-4f56-b16e-0622321cb764@default> (raw)
The examples defining `hungry-mode', and their descriptions, don't
seem completely correct.
Unless a minor mode is declared to be global, which `hungry-mode' is
not, I don't think it defines a user option.
But this doc says:
It puts the variable 'hungry-mode' into custom group 'hunger'.
Does that happen? Even if I define a `hunger' group before evaluating
those `define-minor-mode' sexps I don't see that `M-x customize-group'
gets you to variable `hungry-mode'. But I didn't test much, e.g. with
different `defgroup' definitions for group `hungry'.
My guess is that (1) `:group 'hunger' should be removed from the
examples and (2) the doc should not say that variable `hungry-mode'
is put "into custom group `hunger'. It should not give the impression
that var `hungry-mode' is a user option.
---
I also think it's not so important to show two full examples for the
buffer-local mode, and it might be good to show an example for a global
mode - perhaps even two: (1) using `define-minor-mode' and (2) using
`define-globalized-minor-mode'.
In GNU Emacs 26.2 (build 1, x86_64-w64-mingw32)
of 2019-04-13
Repository revision: fd1b34bfba8f3f6298df47c8e10b61530426f749
Windowing system distributor `Microsoft Corp.', version 10.0.17134
Configured using:
`configure --without-dbus --host=x86_64-w64-mingw32
--without-compress-install 'CFLAGS=-O2 -static -g3''
next reply other threads:[~2019-07-04 15:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 15:33 Drew Adams [this message]
2019-07-08 20:31 ` bug#36501: 26.2; (elisp) `Defining Minor Modes' Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=840640b2-bc37-4f56-b16e-0622321cb764@default \
--to=drew.adams@oracle.com \
--cc=36501@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).