unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#9947: valgrind warning: Conditional jump or move depends on uninitialised value(s) in note_mouse_highlight
@ 2011-11-03 21:41 Dan Nicolaescu
  2011-11-03 22:12 ` Eli Zaretskii
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Nicolaescu @ 2011-11-03 21:41 UTC (permalink / raw)
  To: 9947


valgrind ./temacs -Q

gives this warning:

==7776== Conditional jump or move depends on uninitialised value(s)
==7776==    at 0x4738C5: note_mouse_highlight (xdisp.c:26977)
==7776==    by 0x4F8682: note_mouse_movement (xterm.c:3833)
==7776==    by 0x4FCBB1: handle_one_xevent (xterm.c:6667)
==7776==    by 0x4FD815: XTread_socket (xterm.c:7148)
==7776==    by 0x5438DB: read_avail_input (keyboard.c:6821)
==7776==    by 0x544183: handle_async_input (keyboard.c:7149)
==7776==    by 0x5441A2: process_pending_signals (keyboard.c:7165)
==7776==    by 0x5AACF5: re_match_2_internal (regex.c:5888)
==7776==    by 0x5A6780: re_search_2 (regex.c:4481)
==7776==    by 0x5A57C5: re_search (regex.c:4262)
==7776==    by 0x59260A: fast_string_match (search.c:482)
==7776==    by 0x578870: Ffind_file_name_handler (fileio.c:286)
==7776== 

This is legitimate, the code is looking at the value of "area" inside a conditional:

      if (glyph == NULL
[snip]

"area" is computed by this code:
      /* Find the glyph under X/Y.  */
      glyph = x_y_to_hpos_vpos (w, x, y, &hpos, &vpos, &dx, &dy, &area);

but "area" is not set when `x_y_to_hpos_vpos' return NULL.







^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#9947: valgrind warning: Conditional jump or move depends on uninitialised value(s) in note_mouse_highlight
  2011-11-03 21:41 bug#9947: valgrind warning: Conditional jump or move depends on uninitialised value(s) in note_mouse_highlight Dan Nicolaescu
@ 2011-11-03 22:12 ` Eli Zaretskii
  0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2011-11-03 22:12 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: 9947-done

> From: Dan Nicolaescu <dann@gnu.org>
> Date: Thu, 03 Nov 2011 17:41:27 -0400
> 
> 
> valgrind ./temacs -Q
> 
> gives this warning:
> 
> ==7776== Conditional jump or move depends on uninitialised value(s)
> ==7776==    at 0x4738C5: note_mouse_highlight (xdisp.c:26977)
> ==7776==    by 0x4F8682: note_mouse_movement (xterm.c:3833)
> ==7776==    by 0x4FCBB1: handle_one_xevent (xterm.c:6667)
> ==7776==    by 0x4FD815: XTread_socket (xterm.c:7148)
> ==7776==    by 0x5438DB: read_avail_input (keyboard.c:6821)
> ==7776==    by 0x544183: handle_async_input (keyboard.c:7149)
> ==7776==    by 0x5441A2: process_pending_signals (keyboard.c:7165)
> ==7776==    by 0x5AACF5: re_match_2_internal (regex.c:5888)
> ==7776==    by 0x5A6780: re_search_2 (regex.c:4481)
> ==7776==    by 0x5A57C5: re_search (regex.c:4262)
> ==7776==    by 0x59260A: fast_string_match (search.c:482)
> ==7776==    by 0x578870: Ffind_file_name_handler (fileio.c:286)
> ==7776== 
> 
> This is legitimate, the code is looking at the value of "area" inside a conditional:
> 
>       if (glyph == NULL
> [snip]
> 
> "area" is computed by this code:
>       /* Find the glyph under X/Y.  */
>       glyph = x_y_to_hpos_vpos (w, x, y, &hpos, &vpos, &dx, &dy, &area);
> 
> but "area" is not set when `x_y_to_hpos_vpos' return NULL.

Thanks, fixed.





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-11-03 22:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-03 21:41 bug#9947: valgrind warning: Conditional jump or move depends on uninitialised value(s) in note_mouse_highlight Dan Nicolaescu
2011-11-03 22:12 ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).