From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#9990: valgrind warning in add_row_entry Date: Fri, 18 Nov 2011 14:44:30 +0200 Message-ID: <83zkftbnwx.fsf@gnu.org> References: <83k47ailf0.fsf@gnu.org> <83zkg2fzgt.fsf@gnu.org> <83vcqqfy5h.fsf@gnu.org> <83k475fsxp.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1321620437 7679 80.91.229.12 (18 Nov 2011 12:47:17 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 18 Nov 2011 12:47:17 +0000 (UTC) Cc: 9990@debbugs.gnu.org To: Dan Nicolaescu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 18 13:47:11 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RRNqZ-0007sv-9G for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Nov 2011 13:47:11 +0100 Original-Received: from localhost ([::1]:39899 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRNqY-0008TB-RF for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Nov 2011 07:47:10 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:58573) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRNqV-0008Sz-BK for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2011 07:47:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RRNqU-0006a2-GV for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2011 07:47:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRNqU-0006Zt-C5 for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2011 07:47:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RRNrO-0002eQ-7p for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2011 07:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Nov 2011 12:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9990 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9990-submit@debbugs.gnu.org id=B9990.132162045510152 (code B ref 9990); Fri, 18 Nov 2011 12:48:02 +0000 Original-Received: (at 9990) by debbugs.gnu.org; 18 Nov 2011 12:47:35 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RRNqx-0002dh-KT for submit@debbugs.gnu.org; Fri, 18 Nov 2011 07:47:35 -0500 Original-Received: from mtaout21.012.net.il ([80.179.55.169]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RRNqu-0002dZ-TV for 9990@debbugs.gnu.org; Fri, 18 Nov 2011 07:47:34 -0500 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LUU00800WSP6400@a-mtaout21.012.net.il> for 9990@debbugs.gnu.org; Fri, 18 Nov 2011 14:46:20 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.127.237.133]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LUU007S5WT7YH60@a-mtaout21.012.net.il>; Fri, 18 Nov 2011 14:46:20 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 18 Nov 2011 07:48:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:54036 Archived-At: > From: Dan Nicolaescu > Cc: 9990@debbugs.gnu.org > Date: Tue, 15 Nov 2011 11:58:50 -0500 > > > If the hash values are always correct where they are used, I guess > > that excludes the possibility that we use an uninitialized value, > > right? > > I even added an xassert (verify_row_hash (row)) in add_row_entry, and > it does not trigger. Strange... I added such an assert to the trunk. I also fixed a couple of functions that were destroying the validity of hash codes while manipulating glyph rows. Could you please see if valgrind still complains about add_row_entry with the current trunk?