From: Eli Zaretskii <eliz@gnu.org>
To: Chong Yidong <cyd@gnu.org>
Cc: 6830@debbugs.gnu.org
Subject: bug#6830: widget-complete bad completions in :type 'file
Date: Sun, 04 Mar 2012 19:06:16 +0200 [thread overview]
Message-ID: <83zkbw9tyv.fsf@gnu.org> (raw)
In-Reply-To: <87sjhoiu4q.fsf@gnu.org>
> From: Chong Yidong <cyd@gnu.org>
> Cc: rgm@gnu.org, 6830@debbugs.gnu.org
> Date: Sun, 04 Mar 2012 17:37:57 +0800
>
> As far as the completion code is concerned, the correct field to use is
> the `completion' field assigned by completion-in-region. In this case,
> it's a mistake to pay attention to the underlying widget field. So why
> doesn't it work to give the `completion' overlay a higher priority?
See this fragment from find_field:
before_field
= (XFASTINT (pos) > BEGV
? get_char_property_and_overlay (make_number (XINT (pos) - 1),
Qfield, Qnil, NULL)
/* Using nil here would be a more obvious choice, but it would
fail when the buffer starts with a non-sticky field. */
: after_field);
/* See if we need to handle the case where MERGE_AT_BOUNDARY is nil
and POS is at beginning of a field, which can also be interpreted
as the end of the previous field. Note that the case where if
MERGE_AT_BOUNDARY is non-nil (see function comment) is actually the
more natural one; then we avoid treating the beginning of a field
specially. */
if (NILP (merge_at_boundary))
{
Lisp_Object field = get_pos_property (pos, Qfield, Qnil);
if (!EQ (field, after_field))
at_field_end = 1;
if (!EQ (field, before_field))
at_field_start = 1;
What do you get on GNU/Linux for the values of `field',
`before_field', and `after_field'?
> FWIW, increasing the priority of the `completion' overlay does not cause
> widget file name completion to fail on GNU/Linux. Could you try on
> Windows?
Give me a patch to try, and I will.
next prev parent reply other threads:[~2012-03-04 17:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 11:45 bug#6830: widget-complete bad completions in :type 'file Lennart Borgman
2010-09-04 17:48 ` Chong Yidong
2010-09-04 22:16 ` Lennart Borgman
2010-09-05 1:47 ` Chong Yidong
2012-02-22 21:33 ` Glenn Morris
2012-02-22 23:02 ` Drew Adams
2012-02-22 23:51 ` Drew Adams
2012-02-23 3:57 ` Glenn Morris
2012-02-23 15:27 ` Drew Adams
2012-02-24 19:38 ` Eli Zaretskii
2012-02-25 12:16 ` Richard Stallman
2012-02-24 19:35 ` Eli Zaretskii
2012-02-24 19:47 ` Drew Adams
2012-02-25 3:30 ` Chong Yidong
2012-02-25 5:26 ` Stefan Monnier
2012-02-25 7:45 ` Eli Zaretskii
2012-02-25 6:54 ` Eli Zaretskii
2012-03-04 9:37 ` Chong Yidong
2012-03-04 17:06 ` Eli Zaretskii [this message]
2012-03-05 3:07 ` Chong Yidong
2012-03-05 17:28 ` Eli Zaretskii
2012-03-05 21:28 ` Stefan Monnier
2012-03-06 3:50 ` Eli Zaretskii
2012-03-06 20:45 ` Stefan Monnier
2012-03-06 21:12 ` Eli Zaretskii
2012-03-07 22:09 ` Stefan Monnier
2012-03-09 9:14 ` Eli Zaretskii
2012-03-09 16:35 ` Stefan Monnier
2012-03-09 16:46 ` Stefan Monnier
2012-03-12 8:36 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zkbw9tyv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=6830@debbugs.gnu.org \
--cc=cyd@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).