From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#13065: Bug in x-file-dialog with GetOpenFileName Date: Tue, 22 Jan 2013 15:32:41 +0200 Message-ID: <83zk01mjgm.fsf@gnu.org> References: <83liddr5u8.fsf@gnu.org> <87pq1fhlbo.fsf@gnu.org> <83r4lvgydf.fsf@gnu.org> <87fw251bzq.fsf@gnu.org> <83boctrqg2.fsf@gnu.org> <83wqve8gsz.fsf@gnu.org> <87sj61uxjc.fsf@gnu.org> <83fw217ycy.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1358861578 28177 80.91.229.3 (22 Jan 2013 13:32:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 22 Jan 2013 13:32:58 +0000 (UTC) Cc: 13065-done@debbugs.gnu.org To: jasonr@gnu.org, duyanning@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 22 14:33:16 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TxdyV-0004F0-HZ for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Jan 2013 14:33:15 +0100 Original-Received: from localhost ([::1]:59830 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TxdyE-0002hN-Dc for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Jan 2013 08:32:58 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:35751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TxdyB-0002gt-NS for bug-gnu-emacs@gnu.org; Tue, 22 Jan 2013 08:32:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Txdy9-0000AB-6c for bug-gnu-emacs@gnu.org; Tue, 22 Jan 2013 08:32:55 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38932) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Txdy9-0000A0-25 for bug-gnu-emacs@gnu.org; Tue, 22 Jan 2013 08:32:53 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TxdzG-0007w6-3m for bug-gnu-emacs@gnu.org; Tue, 22 Jan 2013 08:34:02 -0500 Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Jan 2013 13:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 13065 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: Mail-Followup-To: 13065@debbugs.gnu.org, eliz@gnu.org, duyanning@gmail.com Original-Received: via spool by 13065-done@debbugs.gnu.org id=D13065.135886163730493 (code D ref 13065); Tue, 22 Jan 2013 13:34:01 +0000 Original-Received: (at 13065-done) by debbugs.gnu.org; 22 Jan 2013 13:33:57 +0000 Original-Received: from localhost ([127.0.0.1]:44395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TxdzA-0007vm-Nw for submit@debbugs.gnu.org; Tue, 22 Jan 2013 08:33:56 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:62479) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Txdz9-0007vf-9i for 13065-done@debbugs.gnu.org; Tue, 22 Jan 2013 08:33:55 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MH100E0041WW200@a-mtaout22.012.net.il> for 13065-done@debbugs.gnu.org; Tue, 22 Jan 2013 15:32:25 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MH100E5L49YXE00@a-mtaout22.012.net.il>; Tue, 22 Jan 2013 15:32:22 +0200 (IST) In-reply-to: <83fw217ycy.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:70165 Archived-At: > Date: Wed, 16 Jan 2013 20:54:05 +0200 > From: Eli Zaretskii > Cc: 13065@debbugs.gnu.org, duyanning@gmail.com > > So, unless someone has a better idea, I will soon commit to the > emacs-24 branch the patch shown below. It fixes the problem on > Windows 7 and does not affect XP in any visible way. The initial > amount of memory to reserve was found by trial and error. > > (After this patch, the original recipe still doesn't work: you need to > type "abc" _after_ clicking "Desktop". But the same happens with > Emacs 23, so I guess this is just a minor change in behavior of > Windows 7.) > > === modified file 'src/w32heap.c' > --- src/w32heap.c 2013-01-01 09:11:05 +0000 > +++ src/w32heap.c 2013-01-16 18:34:38 +0000 > @@ -98,7 +98,11 @@ allocate_heap (void) > #ifdef _WIN64 > size_t size = 0x4000000000i64; /* start by asking for 32GB */ > #else > - size_t size = 0x80000000; /* start by asking for 2GB */ > + /* We used to start with 2GB here, but on Windows 7 that would leave > + too little room in the address space for threads started by > + Windows on our behalf, e.g. when we pop up the file selection > + dialog. */ > + size_t size = 0x68000000; /* start by asking for 1.7GB */ > #endif > void *ptr = NULL; No further comments, so I committed this to the emacs-24 branch (revision 111192), and I'm closing this bug report.