From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#14233: 24.3; Don't constrain frame size to character multiples Date: Tue, 23 Apr 2013 19:48:38 +0300 Message-ID: <83zjwpw5uh.fsf@gnu.org> References: <2r7gjy2gyy.fsf@fencepost.gnu.org> <83bo991z00.fsf@gnu.org> <517257A0.4080607@gmx.at> <071A708E-3A98-4D11-A15F-7AB92D5200DD@swipnet.se> <51727563.70905@gmx.at> <5172908F.7090206@swipnet.se> <83sj2lz6nm.fsf@gnu.org> <5172EBEF.7030301@swipnet.se> <5173B0D8.4010408@gmx.at> <9CE9273D-8550-478F-8CB9-0C0D693C0BB8@swipnet.se> <5175042E.5020508@gmx.at> <5064BF03-8A61-4C0E-AA6C-5197A177B61A@swipnet.se> <517558ED.7080907@gmx.at> <5175679B.8010903@gmx.at> <868917EF-7586-4F0D-BCDA-0B6F83FBB0A6@swipnet.se> <51767F8E.7000106@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1366736399 8670 80.91.229.3 (23 Apr 2013 16:59:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Apr 2013 16:59:59 +0000 (UTC) Cc: esabof@gmail.com, 14233@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 23 19:00:03 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UUgZW-0002Zm-P6 for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Apr 2013 19:00:02 +0200 Original-Received: from localhost ([::1]:45251 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUgZW-0000Yf-Do for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Apr 2013 13:00:02 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUgZS-0000YL-OG for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2013 12:59:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUgZR-0004xe-G3 for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2013 12:59:58 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUgPt-0001fp-KJ for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2013 12:50:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UUgUg-00057m-Fv for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2013 12:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Apr 2013 16:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14233 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14233-submit@debbugs.gnu.org id=B14233.136673604819584 (code B ref 14233); Tue, 23 Apr 2013 16:55:02 +0000 Original-Received: (at 14233) by debbugs.gnu.org; 23 Apr 2013 16:54:08 +0000 Original-Received: from localhost ([127.0.0.1]:39291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UUgTn-00055p-Iy for submit@debbugs.gnu.org; Tue, 23 Apr 2013 12:54:07 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:60084) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UUgTi-00055O-Qa for 14233@debbugs.gnu.org; Tue, 23 Apr 2013 12:54:04 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MLP00800VXISJ00@a-mtaout23.012.net.il> for 14233@debbugs.gnu.org; Tue, 23 Apr 2013 19:48:40 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MLP008R9W13QE50@a-mtaout23.012.net.il>; Tue, 23 Apr 2013 19:48:40 +0300 (IDT) In-reply-to: <51767F8E.7000106@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73608 Archived-At: > Date: Tue, 23 Apr 2013 14:33:18 +0200 > From: martin rudalics > CC: Eli Zaretskii , "esabof@gmail.com" , > "14233@debbugs.gnu.org" <14233@debbugs.gnu.org> > > > We do have macros like FRAME_MENUBAR_HEIGHT and FRAME_TOOLBAR_HEIGHT > > that can be used. It is better to have that calculation in one place, > > rather than in each port, so this might be a good time to move it. > > If someone wants and knows how to do this cleanly, please go for it. Can you explain what macros/functions would you like to have, exactly, to be able to do this job cleanly? Maybe FRAME_MENUBAR_HEIGHT etc. are not what you need, but perhaps there are other means to get the information cleanly. > > That is one occasion where a pixel-function is needed. But for most calls, pixel precision is not needed. These are the non-tile/fullscreen/maxmimized cases in X and NS. > > I need them for the fullscreen/maximized case on X and NS as well when > the screen estate assigned to Emacs is not a multiple of its character > size. I think we should postpone this argument until you are able to present some code, including its influence on the callers of change_frame_size.