From: Eli Zaretskii <eliz@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 16048@debbugs.gnu.org
Subject: bug#16048: 24.3.50; String compare surprise
Date: Wed, 04 Dec 2013 19:34:37 +0200 [thread overview]
Message-ID: <83zjog34gi.fsf@gnu.org> (raw)
In-Reply-To: <878uw0ogoj.fsf@gmx.de>
> From: Michael Albinus <michael.albinus@gmx.de>
> Date: Wed, 04 Dec 2013 15:05:00 +0100
> Cc: 16048-done@debbugs.gnu.org
>
> Ah, well. In `dbus-unescape-from-identifier', there is
>
> (lambda (x) (format "%c" (string-to-number (substring x 1) 16)))
>
> If I replace it by
>
> (lambda (x) (byte-to-string (string-to-number (substring x 1) 16)))
>
> everything works fine.
Beware: byte-to-string returns a unibyte string. You do NOT want
unibyte strings in your application code. The problem you had that
started this thread is a very good demonstration why.
So I would leave dbus-unescape-from-identifier intact, and instead fix
the other side of the string comparison, the one that yields "\377".
next prev parent reply other threads:[~2013-12-04 17:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 11:44 bug#16048: 24.3.50; String compare surprise michael.albinus
2013-12-04 13:07 ` Andreas Schwab
2013-12-04 14:00 ` Josh
2013-12-04 17:29 ` Eli Zaretskii
2013-12-04 20:13 ` Josh
2013-12-04 14:05 ` Michael Albinus
2013-12-04 17:34 ` Eli Zaretskii [this message]
2013-12-04 19:12 ` Stefan Monnier
2013-12-05 7:51 ` Michael Albinus
2013-12-05 17:38 ` Eli Zaretskii
2013-12-05 19:11 ` Stefan Monnier
2013-12-05 19:18 ` Eli Zaretskii
2013-12-05 19:24 ` Michael Albinus
2013-12-05 19:22 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zjog34gi.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=16048@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).