From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#17975: 24.3.92; assertion failure deleting frames with varying names for the same display (and, using multiple X11 connections in that case too) Date: Sun, 13 Jul 2014 19:35:42 +0300 Message-ID: <83zjgd8bdt.fsf@gnu.org> References: <6ea98jsjtd.fsf@just-testing.permabit.com> <53BCD52D.6090700@yandex.ru> <6eoawv616e.fsf@just-testing.permabit.com> <53C21C84.6030207@yandex.ru> <53C26427.2050103@yandex.ru> <53C265DA.9070103@yandex.ru> <831ttp9u73.fsf@gnu.org> <53C2ABA7.9080907@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1405269384 13732 80.91.229.3 (13 Jul 2014 16:36:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 13 Jul 2014 16:36:24 +0000 (UTC) Cc: raeburn@permabit.com, 17975@debbugs.gnu.org To: Dmitry Antipov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 13 18:36:17 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X6Ml7-0000oU-5S for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Jul 2014 18:36:17 +0200 Original-Received: from localhost ([::1]:52930 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X6Ml6-00043B-Mk for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Jul 2014 12:36:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43388) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X6Mky-00041X-7H for bug-gnu-emacs@gnu.org; Sun, 13 Jul 2014 12:36:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X6Mks-0000zx-QG for bug-gnu-emacs@gnu.org; Sun, 13 Jul 2014 12:36:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58586) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X6Mks-0000zY-OA for bug-gnu-emacs@gnu.org; Sun, 13 Jul 2014 12:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X6Mks-0007BK-1a for bug-gnu-emacs@gnu.org; Sun, 13 Jul 2014 12:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Jul 2014 16:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17975 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17975-submit@debbugs.gnu.org id=B17975.140526934427577 (code B ref 17975); Sun, 13 Jul 2014 16:36:01 +0000 Original-Received: (at 17975) by debbugs.gnu.org; 13 Jul 2014 16:35:44 +0000 Original-Received: from localhost ([127.0.0.1]:53852 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X6MkZ-0007Ag-Gv for submit@debbugs.gnu.org; Sun, 13 Jul 2014 12:35:43 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:53365) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X6MkV-0007AM-7q for 17975@debbugs.gnu.org; Sun, 13 Jul 2014 12:35:41 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0N8N00100SIH4O00@a-mtaout22.012.net.il> for 17975@debbugs.gnu.org; Sun, 13 Jul 2014 19:35:32 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N8N000VCSR7TU50@a-mtaout22.012.net.il>; Sun, 13 Jul 2014 19:35:32 +0300 (IDT) In-reply-to: <53C2ABA7.9080907@yandex.ru> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91509 Archived-At: > Date: Sun, 13 Jul 2014 19:54:15 +0400 > From: Dmitry Antipov > CC: raeburn@permabit.com, 17975@debbugs.gnu.org > > On 07/13/2014 07:04 PM, Eli Zaretskii wrote: > > > Does it help to avoid calling update_menu_bar for frames that don't > > pass the FRAME_LIVE_P test? > > If you mean just this: > > === modified file 'src/xdisp.c' > --- src/xdisp.c 2014-07-12 17:53:29 +0000 > +++ src/xdisp.c 2014-07-13 15:32:01 +0000 > @@ -11698,7 +11698,8 @@ > } > > GCPRO1 (tail); > - menu_bar_hooks_run = update_menu_bar (f, 0, menu_bar_hooks_run); > + if (FRAME_LIVE_P (f)) > + menu_bar_hooks_run = update_menu_bar (f, 0, menu_bar_hooks_run); > #ifdef HAVE_WINDOW_SYSTEM > update_tool_bar (f, 0); > #endif > > then no, at least for Ken's test case. No, I meant to skip the entire loop for non-live frames, like we do for tooltip frames. If this doesn't fix the crash, then please show the backtrace, because the previous one started with the update_menu_bar call. If it is called for a frame other than the one just deleted, then what exactly is the reason for the crash? Why is the frame's display structure NULL?