From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20802: Segfault when showing non-GTK+ tooltip Date: Mon, 15 Jun 2015 18:01:58 +0300 Message-ID: <83zj41nhg9.fsf@gnu.org> References: <1434187118.10061.4.camel@gmx.de> <83381wq76d.fsf@gnu.org> <557C0526.5050607@gmx.at> <831thfri91.fsf@gnu.org> <557C2EF2.5030308@gmx.at> <83vberpv07.fsf@gnu.org> <557C3E1F.6030305@gmx.at> <83twubpt43.fsf@gnu.org> <557D5EE9.7070902@gmx.at> <83h9qapee0.fsf@gnu.org> <557E8B50.80905@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1434380608 1040 80.91.229.3 (15 Jun 2015 15:03:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 15 Jun 2015 15:03:28 +0000 (UTC) Cc: tobias.getzner@gmx.de, 20802@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 15 17:03:16 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z4Vut-0003pI-Bu for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Jun 2015 17:03:15 +0200 Original-Received: from localhost ([::1]:34662 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4Vus-0007XG-KW for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Jun 2015 11:03:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49455) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4Vul-0007Wt-TU for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2015 11:03:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4Vuh-0006Gi-4W for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2015 11:03:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40379) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4Vuh-0006Ge-0z for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2015 11:03:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z4Vug-0006yg-EK for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2015 11:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Jun 2015 15:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20802 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20802-submit@debbugs.gnu.org id=B20802.143438054526742 (code B ref 20802); Mon, 15 Jun 2015 15:03:02 +0000 Original-Received: (at 20802) by debbugs.gnu.org; 15 Jun 2015 15:02:25 +0000 Original-Received: from localhost ([127.0.0.1]:54839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z4Vu4-0006xD-PQ for submit@debbugs.gnu.org; Mon, 15 Jun 2015 11:02:25 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:46428) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z4Vu1-0006wo-N9 for 20802@debbugs.gnu.org; Mon, 15 Jun 2015 11:02:22 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NPZ00D00QV2WC00@a-mtaout20.012.net.il> for 20802@debbugs.gnu.org; Mon, 15 Jun 2015 18:02:13 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NPZ00D0FR3OX200@a-mtaout20.012.net.il>; Mon, 15 Jun 2015 18:02:13 +0300 (IDT) In-reply-to: <557E8B50.80905@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103961 Archived-At: > Date: Mon, 15 Jun 2015 10:22:40 +0200 > From: martin rudalics > CC: tobias.getzner@gmx.de, 20802@debbugs.gnu.org > > > Thanks. Now I know why this cannot be reproduced on Windows: this is > > bug#17524 coming back to haunt us. That bug was reported on Windows, > > I fixed it on Windows, then suggested a similar fix for X, but was > > told it didn't help there. > > > > So now please try making a fix on X similar to commit ebdc80316, and > > if that indeed doesn't help with this crash, perhaps some simple > > variation of that will. > > Sorry. I must be missing something very elementary here. Your "shadow" > refcounts > > #ifdef GLYPH_DEBUG > static int image_cache_refcount, dpyinfo_refcount; > #endif > > are defined iff you have GLYPH_DEBUG defined. How are these supposed to > work when GLYPH_DEBUG is not defined? It cannot, obviously. Bug#17524 was reported in the GLYPH_DEBUG code: the assertion there segfaulted when it tried to access the image cache. So the code was fixed only for that situation. Doing that for a non-GLYPH_DEBUG code will require the shadow variable to come out of that condition as well. Or use some other flag variable to indicate that x_free_frame_resources is about to be called when the refcount was not yet incremented. IOW, that bug was mentioned as a source of ideas, not as something to copy verbatim to xfns.c. Sorry if I was unclear about that.