From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: lekktu@gmail.com, 21816@debbugs.gnu.org, stephen_leake@stephe-leake.org
Subject: bug#21816: elisp-mode-tests fails on a case-preserving filesystem
Date: Tue, 03 Nov 2015 18:34:44 +0200 [thread overview]
Message-ID: <83ziyvujmj.fsf@gnu.org> (raw)
In-Reply-To: <5638DE4A.308@yandex.ru>
> Cc: Eli Zaretskii <eliz@gnu.org>, 21816@debbugs.gnu.org,
> Stephen Leake <stephen_leake@stephe-leake.org>
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Tue, 3 Nov 2015 18:18:18 +0200
>
> On 11/03/2015 06:04 PM, Juanma Barranquero wrote:
>
> > I'm not sure where you're arguing that
> >
> > a) xrefs never need to be compared
> > b) they are sometimes, but it's ok to use equal and fail in
> > case-preserving and case-insensitive systems
>
> Why don't we canonicalize the file name somehow when an xref instance is
> created?
Both forms (and some additional ones) are perfectly canonical.
> > I'm a bit surprised to be discussing that the basic type offered by an
> > infrastructure library as xref needs ways to be compared...
>
> Compared in an impementation-specialized way? Yes, I'd like to see a use
> case.
>
> It's very nontrivial to write a comparison function that would work
> beyond the type you're currently defining (just one xref subtype).
> Hence, its applicability will probably be rather limited.
This isn't a xref-specific problem, so I think it should have a more
general solution that any package could use. It's not reasonable to
expect from every Emacs developer to be an expert on subtle aspects of
comparing Windows file names. We should provide a tested solution for
that.
next prev parent reply other threads:[~2015-11-03 16:34 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 16:41 bug#21816: elisp-mode-tests fails on a case-preserving filesystem Juanma Barranquero
2015-11-02 17:57 ` Eli Zaretskii
2015-11-02 18:20 ` Juanma Barranquero
2015-11-03 1:19 ` Juanma Barranquero
2015-11-03 3:42 ` Eli Zaretskii
2015-11-03 9:17 ` Stephen Leake
2015-11-03 10:06 ` Juanma Barranquero
2015-11-03 14:51 ` Stephen Leake
2015-11-03 14:58 ` Juanma Barranquero
2015-11-03 19:43 ` Stephen Leake
2015-11-03 22:24 ` Stephen Leake
2015-11-04 8:48 ` Juanma Barranquero
2015-11-09 3:38 ` Dmitry Gutov
2019-10-02 0:57 ` Juanma Barranquero
2015-11-03 15:40 ` Eli Zaretskii
2015-11-03 15:45 ` Juanma Barranquero
2015-11-03 15:52 ` Dmitry Gutov
2015-11-03 16:04 ` Juanma Barranquero
2015-11-03 16:18 ` Dmitry Gutov
2015-11-03 16:33 ` Juanma Barranquero
2015-11-03 18:12 ` Dmitry Gutov
2015-11-04 8:40 ` Juanma Barranquero
2015-11-03 16:34 ` Eli Zaretskii [this message]
2015-11-03 16:42 ` Juanma Barranquero
2015-11-03 16:53 ` Eli Zaretskii
2015-11-03 18:13 ` Dmitry Gutov
2015-11-03 19:54 ` Random832
2015-11-03 20:03 ` Dmitry Gutov
2015-11-03 20:25 ` Random832
2015-11-03 21:25 ` Dmitry Gutov
2015-11-03 20:51 ` Eli Zaretskii
2015-11-04 8:19 ` Juanma Barranquero
2015-11-03 18:18 ` Dmitry Gutov
2015-11-03 20:56 ` Eli Zaretskii
2015-11-04 8:53 ` Juanma Barranquero
2015-11-03 19:50 ` Random832
2015-11-03 21:02 ` Eli Zaretskii
2015-11-03 21:17 ` Random832
2015-11-03 21:22 ` Eli Zaretskii
2015-11-03 19:54 ` Stephen Leake
2015-11-03 20:05 ` Dmitry Gutov
2015-11-03 21:07 ` Eli Zaretskii
2015-11-03 21:52 ` Stephen Leake
2015-11-03 22:07 ` Stephen Leake
2015-11-03 22:18 ` Dmitry Gutov
2015-11-03 22:20 ` Stephen Leake
2015-11-04 3:46 ` Eli Zaretskii
2015-11-04 8:28 ` Stephen Leake
2015-11-04 5:24 ` Alexis
2015-11-04 6:33 ` Random832
2015-11-04 6:52 ` Alexis
2015-11-04 15:35 ` Eli Zaretskii
2015-11-04 15:38 ` Eli Zaretskii
2015-11-04 9:04 ` Stephen Leake
2015-11-04 10:37 ` Alexis
2015-11-04 16:08 ` Eli Zaretskii
2015-11-04 15:34 ` Eli Zaretskii
2015-11-03 21:05 ` Eli Zaretskii
2015-11-03 21:58 ` Stephen Leake
2015-11-04 3:42 ` Eli Zaretskii
2015-11-04 10:00 ` Stephen Leake
2015-11-04 19:14 ` Stephen Leake
2015-11-03 19:24 ` Stephen Leake
2015-11-03 21:00 ` Eli Zaretskii
2015-11-04 15:29 ` Stephen Leake
2015-11-05 12:26 ` Juanma Barranquero
2015-11-05 13:23 ` Stephen Leake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ziyvujmj.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=21816@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=lekktu@gmail.com \
--cc=stephen_leake@stephe-leake.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).