From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22096: 25.0.50; reading from fifo breaks display Date: Sat, 05 Dec 2015 21:38:23 +0200 Message-ID: <83zixoele8.fsf@gnu.org> References: <87lh9aglih.fsf@udel.edu> <87wpss7nr9.fsf@udel.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1449344363 25675 80.91.229.3 (5 Dec 2015 19:39:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 5 Dec 2015 19:39:23 +0000 (UTC) Cc: 22096@debbugs.gnu.org To: Mark Oteiza , Kenichi Handa Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 05 20:39:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a5Ifn-00030o-0X for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Dec 2015 20:39:11 +0100 Original-Received: from localhost ([::1]:47549 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5Ifm-0002PK-Au for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Dec 2015 14:39:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5Ifi-0002P2-6W for bug-gnu-emacs@gnu.org; Sat, 05 Dec 2015 14:39:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a5Ife-0007Gk-Q3 for bug-gnu-emacs@gnu.org; Sat, 05 Dec 2015 14:39:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50395) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5Ife-0007Gg-MS for bug-gnu-emacs@gnu.org; Sat, 05 Dec 2015 14:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a5Ife-0003Yb-FG for bug-gnu-emacs@gnu.org; Sat, 05 Dec 2015 14:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Dec 2015 19:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22096 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22096-submit@debbugs.gnu.org id=B22096.144934431613633 (code B ref 22096); Sat, 05 Dec 2015 19:39:02 +0000 Original-Received: (at 22096) by debbugs.gnu.org; 5 Dec 2015 19:38:36 +0000 Original-Received: from localhost ([127.0.0.1]:40103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a5IfE-0003Xo-Ah for submit@debbugs.gnu.org; Sat, 05 Dec 2015 14:38:36 -0500 Original-Received: from mtaout27.012.net.il ([80.179.55.183]:58832) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a5IfC-0003Xe-Gh for 22096@debbugs.gnu.org; Sat, 05 Dec 2015 14:38:35 -0500 Original-Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0NYW00900GMR2700@mtaout27.012.net.il> for 22096@debbugs.gnu.org; Sat, 05 Dec 2015 21:33:40 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NYW001FZH0401C0@mtaout27.012.net.il>; Sat, 05 Dec 2015 21:33:40 +0200 (IST) In-reply-to: <87wpss7nr9.fsf@udel.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109669 Archived-At: > From: Mark Oteiza > Date: Sat, 05 Dec 2015 13:29:14 -0500 > > Simpler recipe: > > 1. mkfifo foo > 2. echo "bar" > foo > > In emacs -Q: > > 3. Evaluate (insert-file-contents-literally "foo" t) > > The buffer display is now broken. Thanks. My Emacs is configured with --enable-checking, so it aborted due to assertion violation. The patch below fixes that for me; please see if it fixes the display problem for you. Does anyone understand how come we used just bset_enable_multibyte_characters, bypassing all the rest that is required to make a non-empty buffer unibyte? It looks simply blatantly wrong to me. Compare, for example, with what decide_coding_unwind does. Did we never execute this particular code since it was written, at least not for non-empty buffers? I hope Handa-san (CC'ed) could comment on this. diff --git a/src/fileio.c b/src/fileio.c index 6cda1e3..8e44eb0 100644 --- a/src/fileio.c +++ b/src/fileio.c @@ -4265,7 +4265,7 @@ by calling `format-decode', which see. */) && NILP (replace)) /* Visiting a file with these coding system makes the buffer unibyte. */ - bset_enable_multibyte_characters (current_buffer, Qnil); + Fset_buffer_multibyte (Qnil); } coding.dst_multibyte = ! NILP (BVAR (current_buffer, enable_multibyte_charac\ ters));