From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22114: 24.5; [PATCH] Allow profiler.el to display reports after stopping Date: Tue, 08 Dec 2015 20:08:44 +0200 Message-ID: <83zixkbyoj.fsf@gnu.org> References: <83bna0di5k.fsf@gnu.org> <20151208163208.GA1080@odonien.bevuta.com> <837fkodf3e.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1449598165 10464 80.91.229.3 (8 Dec 2015 18:09:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Dec 2015 18:09:25 +0000 (UTC) Cc: 22114@debbugs.gnu.org, v.schneidermann@gmail.com To: John Wiegley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 08 19:09:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a6MhM-0002zM-8j for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Dec 2015 19:09:12 +0100 Original-Received: from localhost ([::1]:32899 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6MhL-00087U-DC for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Dec 2015 13:09:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6MhH-000877-Uv for bug-gnu-emacs@gnu.org; Tue, 08 Dec 2015 13:09:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a6MhC-00041B-Uj for bug-gnu-emacs@gnu.org; Tue, 08 Dec 2015 13:09:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53793) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6MhC-000414-R9 for bug-gnu-emacs@gnu.org; Tue, 08 Dec 2015 13:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a6MhC-0001Be-Dd for bug-gnu-emacs@gnu.org; Tue, 08 Dec 2015 13:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Dec 2015 18:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22114 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22114-submit@debbugs.gnu.org id=B22114.14495981304542 (code B ref 22114); Tue, 08 Dec 2015 18:09:02 +0000 Original-Received: (at 22114) by debbugs.gnu.org; 8 Dec 2015 18:08:50 +0000 Original-Received: from localhost ([127.0.0.1]:43501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a6Mh0-0001BC-4N for submit@debbugs.gnu.org; Tue, 08 Dec 2015 13:08:50 -0500 Original-Received: from mtaout28.012.net.il ([80.179.55.184]:55602) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a6Mgx-0001B1-H2 for 22114@debbugs.gnu.org; Tue, 08 Dec 2015 13:08:48 -0500 Original-Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NZ100I00WSD4T00@mtaout28.012.net.il> for 22114@debbugs.gnu.org; Tue, 08 Dec 2015 20:07:55 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NZ100FVQX17WU20@mtaout28.012.net.il>; Tue, 08 Dec 2015 20:07:55 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109780 Archived-At: > From: John Wiegley > Cc: Vasilij Schneidermann , 22114@debbugs.gnu.org > Date: Tue, 08 Dec 2015 09:42:37 -0800 > > > But why would you need a subsequent access to the same data? The profiler > > report is in the buffer, and you can review it whenever you want. The buffer > > has the time of the report creation as part of its name, so the next report > > will not destroy the buffer. You can also save the report to a file (there's > > a separate command to do that). By contrast,producing a report again from > > the same data will simply produce an identical report. > > > I guess I don't see a use case where the user would need to produce the same > > report twice. I never needed that myself, FWIW. > > I think the OP wants to: > > 1. Start a profile > 2. View the "results in progress" > 3. Allow it to continue execution > 4. View the "results at the end" > > It's step #2 that's missing. If we can only view the results in progress by > taking away the option for #4, this is less optimal. This is a completely different issue, and AFAIU the proposed patch didn't allow that. The C-level implementation of producing a profiler log (which is then used to format a report) resets the profile data once it returns the log, and then starts collecting the profile data anew. The OP's patch didn't change that.