From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line Date: Sun, 11 Sep 2016 20:16:51 +0300 Message-ID: <83zine9x18.fsf@gnu.org> References: <83a8febg8c.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1473614325 30007 195.159.176.226 (11 Sep 2016 17:18:45 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 11 Sep 2016 17:18:45 +0000 (UTC) Cc: 24409@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 11 19:18:42 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bj8Ob-0005K9-QT for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Sep 2016 19:18:21 +0200 Original-Received: from localhost ([::1]:38476 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bj8OZ-0006QR-Uz for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Sep 2016 13:18:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bj8ON-0006PH-Ed for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2016 13:18:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bj8OI-0001DF-D7 for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2016 13:18:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bj8OI-0001DB-AH for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2016 13:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bj8OI-0003sl-5U for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2016 13:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Sep 2016 17:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24409 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24409-submit@debbugs.gnu.org id=B24409.147361423114839 (code B ref 24409); Sun, 11 Sep 2016 17:18:02 +0000 Original-Received: (at 24409) by debbugs.gnu.org; 11 Sep 2016 17:17:11 +0000 Original-Received: from localhost ([127.0.0.1]:56670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bj8NT-0003rH-HC for submit@debbugs.gnu.org; Sun, 11 Sep 2016 13:17:11 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bj8NR-0003r0-Tn for 24409@debbugs.gnu.org; Sun, 11 Sep 2016 13:17:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bj8NI-0000vW-Lp for 24409@debbugs.gnu.org; Sun, 11 Sep 2016 13:17:04 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50660) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bj8NI-0000v5-Ia; Sun, 11 Sep 2016 13:17:00 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1306 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bj8NB-0000b1-Cg; Sun, 11 Sep 2016 13:16:54 -0400 In-reply-to: (message from Tino Calancha on Mon, 12 Sep 2016 02:03:14 +0900 (JST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123184 Archived-At: > From: Tino Calancha > Date: Mon, 12 Sep 2016 02:03:14 +0900 (JST) > cc: Tino Calancha , 24409@debbugs.gnu.org > > *) Please, take a look in the new patch below with more verbose log > message/comments. Thanks, see a follow-up comment below. > *) Where should go the fix: emacs-25 branch or master? Master, of course. > - (let* ((file (or file-name buffer-file-name)) > + ;; Expand file-name before calling `dired-goto-file': > + ;; This is required in interactive calls because the return value > + ;; of `read-file-name' is not expanded; it also helps in > + ;; non-interactive calls, where file-name could be an abbreviated > + ;; file name as ~/dir/file (Bug#24409). > + (let* ((file (or (and file-name (expand-file-name file-name)) > + buffer-file-name)) I think a better comment would be to say that dired-goto-file requires its argument to be an absolute file name, and the result of read-file-name could be an abbreviated file name.