From: Eli Zaretskii <eliz@gnu.org>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: 24409@debbugs.gnu.org
Subject: bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line
Date: Sun, 11 Sep 2016 20:16:51 +0300 [thread overview]
Message-ID: <83zine9x18.fsf@gnu.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1609120159040.14684@calancha-pc> (message from Tino Calancha on Mon, 12 Sep 2016 02:03:14 +0900 (JST))
> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Mon, 12 Sep 2016 02:03:14 +0900 (JST)
> cc: Tino Calancha <tino.calancha@gmail.com>, 24409@debbugs.gnu.org
>
> *) Please, take a look in the new patch below with more verbose log
> message/comments.
Thanks, see a follow-up comment below.
> *) Where should go the fix: emacs-25 branch or master?
Master, of course.
> - (let* ((file (or file-name buffer-file-name))
> + ;; Expand file-name before calling `dired-goto-file':
> + ;; This is required in interactive calls because the return value
> + ;; of `read-file-name' is not expanded; it also helps in
> + ;; non-interactive calls, where file-name could be an abbreviated
> + ;; file name as ~/dir/file (Bug#24409).
> + (let* ((file (or (and file-name (expand-file-name file-name))
> + buffer-file-name))
I think a better comment would be to say that dired-goto-file requires
its argument to be an absolute file name, and the result of
read-file-name could be an abbreviated file name.
next prev parent reply other threads:[~2016-09-11 17:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-11 4:33 bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line Tino Calancha
2016-09-11 4:42 ` Noam Postavsky
2016-09-11 4:50 ` Tino Calancha
2016-09-11 15:36 ` Eli Zaretskii
2016-09-11 17:03 ` Tino Calancha
2016-09-11 17:16 ` Eli Zaretskii [this message]
2016-09-12 4:37 ` Tino Calancha
2016-09-12 16:53 ` Eli Zaretskii
2016-09-13 7:04 ` Tino Calancha
2016-09-13 14:37 ` Eli Zaretskii
2016-09-13 15:09 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zine9x18.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=24409@debbugs.gnu.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).