unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Hong Xu <hong@topbug.net>
Cc: 24861@debbugs.gnu.org
Subject: bug#24861: [PATCH] Fix annoying "Parsing...done" message in c++-mode
Date: Fri, 18 Nov 2016 11:39:42 +0200	[thread overview]
Message-ID: <83zikxcejl.fsf@gnu.org> (raw)
In-Reply-To: <877f84mgu0.fsf@topbug.net> (message from Hong Xu on Tue, 15 Nov 2016 16:03:19 -0800)

> From: Hong Xu <hong@topbug.net>
> Cc: 24861@debbugs.gnu.org
> Date: Tue, 15 Nov 2016 16:03:19 -0800
> 
> Can you still consider this patch?

I'm okay with accepting this for the master branch, but the patch
needs some more work to fix the following issues:

 . The first line of each doc string should be a complete sentence.
 . The doc string of cpp-progress-message should mention
   cpp-message-min-time-interval.
 . The defcustom you are adding should have a :version tag.
 . The calculation in cpp-progress-message should be fixed to
   calculate the time difference between the current time and the time
   of the previous progress message, and compare that with the value
   of cpp-message-min-time-interval.  The old code just looked at the
   2nd member of the list returned by current-time, but that is no
   longer TRT when you need to compare the time difference, because
   that member can go back to zero.  You need to use time-subtract.
 . Last, but not least: please include ChangeLog-style commit log
   message for the changes.

Thanks.





  reply	other threads:[~2016-11-18  9:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-02 18:45 bug#24861: [PATCH] Fix annoying "Parsing...done" message in c++-mode Hong Xu
2016-11-02 20:09 ` Hong Xu
2016-11-02 20:21   ` Eli Zaretskii
2016-11-02 23:34     ` Hong Xu
2016-11-03 18:15       ` Eli Zaretskii
2016-11-03 18:43         ` Hong Xu
2016-11-16  0:03           ` Hong Xu
2016-11-18  9:39             ` Eli Zaretskii [this message]
2016-11-18 19:55               ` Hong Xu
2016-11-19  7:50                 ` Eli Zaretskii
2016-11-20  0:20                   ` Hong Xu
2016-11-25 10:53                     ` Eli Zaretskii
2016-11-02 23:39     ` Hong Xu
2016-11-03 16:39     ` Richard Stallman
2016-11-02 22:05   ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zikxcejl.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=24861@debbugs.gnu.org \
    --cc=hong@topbug.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).