From: Eli Zaretskii <eliz@gnu.org>
To: npostavs@users.sourceforge.net
Cc: 24751@debbugs.gnu.org
Subject: bug#24751: 26.0.50; Regex stack overflow not detected properly (gets "Variable binding depth exceeds max-specpdl-size")
Date: Sun, 01 Jan 2017 20:41:57 +0200 [thread overview]
Message-ID: <83zijafwqy.fsf@gnu.org> (raw)
In-Reply-To: <87lguu7hq8.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net)
> From: npostavs@users.sourceforge.net
> Cc: 24751@debbugs.gnu.org
> Date: Sun, 01 Jan 2017 13:33:35 -0500
>
> Eli Zaretskii <eliz@gnu.org> writes:
> >>
> >> /* Define MATCH_MAY_ALLOCATE unless we need to make sure that the
> >> searching and matching functions should not call alloca. On some
> >> systems, alloca is implemented in terms of malloc, and if we're
> >> using the relocating allocator routines, then malloc could cause a
> >> relocation, which might (if the strings being searched are in the
> >> ralloc heap) shift the data out from underneath the regexp
> >> routines.
> >>
> >> [...]
> >
> > The first part is not obsolete, but its reasoning is backwards:
> > SAFE_ALLOCA indeed can call malloc, but it could only cause relocation
> > if REGEX_MALLOC is defined (and ralloc.c is compiled in). And when
> > you define REGEX_MALLOC, MATCH_MAY_ALLOCATE is undefined. So the text
> > there should be revised.
>
> Is there ever any case where REGEX_MALLOC is defined? I can't see where
> it happens.
I don't understand the question. You can compile regex.c with the
"-DREGEX_MALLOC" option whenever you like. We don't do that, but as
long as the code which supports that is in regex.c, the comment goes
with it.
> I don't understand why you say relocation is dependent on
> REGEX_MALLOC, I thought only REL_ALLOC affects that.
REL_ALLOC determines whether ralloc.c is compiled in, which I
mentioned above.
> And since we added r_alloc_inhibit_buffer_relocation around the regex
> calls, aren't all these concerns about relocation obsolete?
The calls to r_alloc_inhibit_buffer_relocation are outside of regex.c,
so the comments in regex.c don't know anything about that.
next prev parent reply other threads:[~2017-01-01 18:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 3:54 bug#24751: 26.0.50; Regex stack overflow not detected properly (gets "Variable binding depth exceeds max-specpdl-size") npostavs
2016-11-04 8:22 ` Eli Zaretskii
2016-11-05 19:34 ` npostavs
2016-11-06 15:45 ` Eli Zaretskii
2016-11-13 5:39 ` npostavs
2016-11-13 16:12 ` Eli Zaretskii
2016-11-15 3:08 ` npostavs
2016-11-15 16:12 ` Eli Zaretskii
2016-11-16 1:06 ` npostavs
2016-11-16 16:25 ` Eli Zaretskii
2016-11-16 23:25 ` npostavs
2016-11-17 16:21 ` Eli Zaretskii
2016-11-19 10:02 ` Eli Zaretskii
2017-01-01 18:33 ` npostavs
2017-01-01 18:41 ` Eli Zaretskii [this message]
2017-01-01 18:57 ` npostavs
2017-01-01 20:06 ` Eli Zaretskii
2017-01-02 4:49 ` npostavs
2017-01-02 15:24 ` Eli Zaretskii
2017-01-02 18:30 ` npostavs
2017-01-02 19:22 ` Eli Zaretskii
2017-01-08 23:49 ` npostavs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zijafwqy.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=24751@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).