From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25890: `color-values` gives wrong value Date: Fri, 10 Mar 2017 11:25:34 +0200 Message-ID: <83zigteb5d.fsf@gnu.org> References: <87zih7n2yt.fsf@pank.eu> <83a88tfv4a.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1489138030 1736 195.159.176.226 (10 Mar 2017 09:27:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 10 Mar 2017 09:27:10 +0000 (UTC) Cc: 25890@debbugs.gnu.org To: "mail\@yo.eki.do" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 10 10:27:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmGpG-0008W5-H9 for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Mar 2017 10:27:06 +0100 Original-Received: from localhost ([::1]:38144 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cmGpM-0004lW-K5 for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Mar 2017 04:27:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cmGpG-0004lB-HK for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2017 04:27:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cmGpC-0004s7-Cf for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2017 04:27:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50288) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cmGpC-0004rr-85 for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2017 04:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cmGpB-0007aR-Ud for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2017 04:27:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Mar 2017 09:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25890 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25890-submit@debbugs.gnu.org id=B25890.148913796629100 (code B ref 25890); Fri, 10 Mar 2017 09:27:01 +0000 Original-Received: (at 25890) by debbugs.gnu.org; 10 Mar 2017 09:26:06 +0000 Original-Received: from localhost ([127.0.0.1]:48487 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmGoI-0007ZI-Ck for submit@debbugs.gnu.org; Fri, 10 Mar 2017 04:26:06 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:48792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmGoG-0007Yo-Lw for 25890@debbugs.gnu.org; Fri, 10 Mar 2017 04:26:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cmGo7-0004OV-FH for 25890@debbugs.gnu.org; Fri, 10 Mar 2017 04:25:59 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33432) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cmGo7-0004O4-Bp; Fri, 10 Mar 2017 04:25:55 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3833 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cmGo6-0006K6-Kh; Fri, 10 Mar 2017 04:25:55 -0500 In-reply-to: (mail@yo.eki.do) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130429 Archived-At: > From: "mail@yo.eki.do" > Date: Fri, 10 Mar 2017 08:13:15 +0000 > > > The default was changed to 4 to match how Emacs does color > > calculations internally. Using 2 will produce subtle bugs, like that > > one which prompted that change. > > Thanks for clear explanation. > So that basically means this destructive change was inevitable. > I guess you are right. To my defense, they didn't look so destructive when I made them. This function has only one caller in the rest of the Emacs sources. > > > This change actually had impact on several packages including mode-icons, and IMO keeping the original > > > behavior is a better option. > > > > I'm sorry to hear that, but you could still use the optional argument > > to get back the original behavior, right? > > Hopefully. Actually I'm not qute certain how many packages will be affected. Neither am I. I'm open to alternative ideas for how to solve the original bug in a less intrusive way. I just don't think defaulting to 2 would be such an alternative, because the underlying issues are very subtle, and if we continue using 2 as the default, users of that function will never discover that they need to use 4. But maybe there are other ways that leave everyone more happy.