From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event Date: Tue, 28 Nov 2017 19:11:38 +0200 Message-ID: <83zi7649bp.fsf@gnu.org> References: <1b3879d6-f14e-47b0-970f-baf09598fcfd@default> <871skjnpd8.fsf@users.sourceforge.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1511889138 5400 195.159.176.226 (28 Nov 2017 17:12:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 28 Nov 2017 17:12:18 +0000 (UTC) Cc: acm@muc.de, 29478@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 28 18:12:05 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJjQS-0000UI-RQ for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Nov 2017 18:12:04 +0100 Original-Received: from localhost ([::1]:39171 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJjQW-0007jd-PT for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Nov 2017 12:12:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJjQR-0007jY-As for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 12:12:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJjQQ-0004WK-AQ for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 12:12:03 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54476) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eJjQQ-0004WG-7f for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 12:12:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eJjQP-0001tb-QT for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 12:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Nov 2017 17:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29478 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 29478-submit@debbugs.gnu.org id=B29478.15118891197279 (code B ref 29478); Tue, 28 Nov 2017 17:12:01 +0000 Original-Received: (at 29478) by debbugs.gnu.org; 28 Nov 2017 17:11:59 +0000 Original-Received: from localhost ([127.0.0.1]:34924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJjQM-0001tL-OO for submit@debbugs.gnu.org; Tue, 28 Nov 2017 12:11:59 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:47159) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJjQI-0001t5-Km for 29478@debbugs.gnu.org; Tue, 28 Nov 2017 12:11:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJjQA-0004Ro-Cx for 29478@debbugs.gnu.org; Tue, 28 Nov 2017 12:11:49 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJjQA-0004Rk-9d; Tue, 28 Nov 2017 12:11:46 -0500 Original-Received: from [176.228.60.248] (port=3172 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eJjQ9-00063m-NH; Tue, 28 Nov 2017 12:11:46 -0500 In-reply-to: <871skjnpd8.fsf@users.sourceforge.net> (message from Noam Postavsky on Mon, 27 Nov 2017 20:50:11 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140492 Archived-At: > From: Noam Postavsky > Date: Mon, 27 Nov 2017 20:50:11 -0500 > Cc: Alan Mackenzie , 29478@debbugs.gnu.org > > Drew Adams writes: > > > The down mouse-button event is no longer listed along with the up > > event when you use `C-h k' with a click event. Dunno whether this was > > by design or is an oversight. > > Looks like oversight. Possibly related to Bug#29272. The following > seems to fix it for me, but I'm having trouble convincing myself that > it's the right thing. > > --- c/lisp/help.el > +++ i/lisp/help.el > @@ -738,7 +738,7 @@ help-read-key-sequence > ;; spuriously trigger the `sit-for'. > (sleep-for 0.01) > (while (read-event nil nil 0.01)) > - (not (sit-for (/ double-click-time 1000.0) t)))))))) > + (sit-for (/ double-click-time 1000.0) t))))))) > (list > key > ;; If KEY is a down-event, read and include the > Not an oversight: the above patch brings back bug#29272.