From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#29478: [Patch] bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event Date: Sat, 23 Dec 2017 14:41:42 +0200 Message-ID: <83zi69k455.fsf@gnu.org> References: <1b3879d6-f14e-47b0-970f-baf09598fcfd@default> <871skjnpd8.fsf@users.sourceforge.net> <20171128221036.GC14868@ACM> <83o9ni3l3i.fsf@gnu.org> <83bmji2xye.fsf@gnu.org> <83tvwzubez.fsf@gnu.org> <20171222220549.GC8072@ACM> <833741lr0t.fsf@gnu.org> <20171223111726.GA6618@ACM> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1514032883 3278 195.159.176.226 (23 Dec 2017 12:41:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 23 Dec 2017 12:41:23 +0000 (UTC) Cc: 29478@debbugs.gnu.org, monnier@iro.umontreal.ca, npostavs@users.sourceforge.net To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 23 13:41:18 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eSj77-0000Ff-BN for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Dec 2017 13:41:17 +0100 Original-Received: from localhost ([::1]:41694 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eSj92-0008Vw-Qt for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Dec 2017 07:43:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eSj8r-0008Vn-82 for bug-gnu-emacs@gnu.org; Sat, 23 Dec 2017 07:43:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eSj8o-0005BI-5e for bug-gnu-emacs@gnu.org; Sat, 23 Dec 2017 07:43:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40105) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eSj8o-0005BC-2D for bug-gnu-emacs@gnu.org; Sat, 23 Dec 2017 07:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eSj8n-0007r6-RY for bug-gnu-emacs@gnu.org; Sat, 23 Dec 2017 07:43:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Dec 2017 12:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29478 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 29478-submit@debbugs.gnu.org id=B29478.151403292830135 (code B ref 29478); Sat, 23 Dec 2017 12:43:01 +0000 Original-Received: (at 29478) by debbugs.gnu.org; 23 Dec 2017 12:42:08 +0000 Original-Received: from localhost ([127.0.0.1]:48786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eSj7w-0007pz-7w for submit@debbugs.gnu.org; Sat, 23 Dec 2017 07:42:08 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:34158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eSj7u-0007pc-Nc for 29478@debbugs.gnu.org; Sat, 23 Dec 2017 07:42:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eSj7m-0004Rr-Ce for 29478@debbugs.gnu.org; Sat, 23 Dec 2017 07:42:01 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42570) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eSj7W-00044U-Hl; Sat, 23 Dec 2017 07:41:42 -0500 Original-Received: from [176.228.60.248] (port=3750 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eSj7V-0008Fb-Lm; Sat, 23 Dec 2017 07:41:42 -0500 In-reply-to: <20171223111726.GA6618@ACM> (message from Alan Mackenzie on Sat, 23 Dec 2017 11:17:26 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141422 Archived-At: > Date: Sat, 23 Dec 2017 11:17:26 +0000 > Cc: Stefan Monnier , 29478@debbugs.gnu.org, > npostavs@users.sourceforge.net > From: Alan Mackenzie > > Of course! read-key-sequence consumes all the events up to the > S-down-mouse-1, leaving the following S-mouse-1 in the event buffer. > This is read at the next iteration of the command loop. > > > CC'ing Stefan in the hope that he could have some insights. > > OK, I have a provisional fix. The problem was that the double-click-time > loop in help-read-key-sequence was discarding all events but the last > one. I have amended the loop so that _all_ these events are stored in a > list, and we then discard the most recent events till we find one with a > binding. > > This patch seems to work with GPM in a Linux tty, and also in X-Windows > (I think). (It is based on the emacs-26 branch, of course.) LGTM, thanks. The problem I reported is gone with this patch.