From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#29478: [Patch] bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event Date: Sat, 06 Jan 2018 19:40:57 +0200 Message-ID: <83zi5q997a.fsf@gnu.org> References: <20171128221036.GC14868@ACM> <83o9ni3l3i.fsf@gnu.org> <83bmji2xye.fsf@gnu.org> <83tvwzubez.fsf@gnu.org> <20171222220549.GC8072@ACM> <833741lr0t.fsf@gnu.org> <20171223111726.GA6618@ACM> <20171223210407.GC6618@ACM> <831sjcfq1v.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1515260433 18716 195.159.176.226 (6 Jan 2018 17:40:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 6 Jan 2018 17:40:33 +0000 (UTC) Cc: acm@muc.de, 29478@debbugs.gnu.org, npostavs@users.sourceforge.net To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 06 18:40:28 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXsS2-0003TC-0k for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Jan 2018 18:40:10 +0100 Original-Received: from localhost ([::1]:43710 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eXsU1-0003K6-Cy for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Jan 2018 12:42:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eXsTv-0003Jf-5i for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2018 12:42:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eXsTq-0003MA-VN for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2018 12:42:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57922) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eXsTq-0003Le-S4 for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2018 12:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eXsTq-0002Hh-Iz for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2018 12:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Jan 2018 17:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29478 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 29478-submit@debbugs.gnu.org id=B29478.15152605088756 (code B ref 29478); Sat, 06 Jan 2018 17:42:02 +0000 Original-Received: (at 29478) by debbugs.gnu.org; 6 Jan 2018 17:41:48 +0000 Original-Received: from localhost ([127.0.0.1]:38370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXsTc-0002HA-2j for submit@debbugs.gnu.org; Sat, 06 Jan 2018 12:41:48 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:57299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXsTa-0002Gx-Mz for 29478@debbugs.gnu.org; Sat, 06 Jan 2018 12:41:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eXsTR-00030F-3D for 29478@debbugs.gnu.org; Sat, 06 Jan 2018 12:41:41 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55239) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eXsTE-0002qX-TM; Sat, 06 Jan 2018 12:41:24 -0500 Original-Received: from [176.228.60.248] (port=2965 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eXsTD-0007mY-0H; Sat, 06 Jan 2018 12:41:24 -0500 In-reply-to: (message from Stefan Monnier on Tue, 02 Jan 2018 22:56:55 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141843 Archived-At: > From: Stefan Monnier > Cc: acm@muc.de, 29478@debbugs.gnu.org, npostavs@users.sourceforge.net > Date: Tue, 02 Jan 2018 22:56:55 -0500 > > > This patch doesn't apply to the master branch, so I couldn't test it. > > It was meant to be read rather than to be applied. Sorry, I'm not good at reading such large patches. > If you want a patch that applies, the one below should work. Thanks. It needs some more work. E.g., "C-h k C-mouse-1" signals an error: help-fns--analyze-function: Symbol’s function definition is void: nil and "C-h k C-mouse-3" followed by a menu selection asks for another key or mouse click, although it already has got a full key sequence. In general, I see the idea is to show both down-mouse-N event and mouse-N event, both with "C-h c" and "C-h k". That could be okay, but why show undefined sequences? E.g, "C-h c S-mouse-1" shows this in the echo area: at that spot runs the command mouse-appearance-menu at that spot is undefined I'd expect the second line not to appear. Also, if both events are bound, I think we should show the mouse-N event before the down-mouse-N event, because the former is much more important and normally is the one that's bound. Thanks.