unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 30141@debbugs.gnu.org, aaronjensen@gmail.com
Subject: bug#30141: (26.0.91; text-pixel dimensions not properly saved by desktop-save-mode sometimes)
Date: Sat, 20 Jan 2018 12:50:38 +0200	[thread overview]
Message-ID: <83zi58st1d.fsf@gnu.org> (raw)
In-Reply-To: <5A631B5D.2090604@gmx.at> (message from martin rudalics on Sat, 20 Jan 2018 11:35:09 +0100)

> Date: Sat, 20 Jan 2018 11:35:09 +0100
> From: martin rudalics <rudalics@gmx.at>
> 
>  > The issue is when you have the frame sized to be a
>  > non-multiple of the font-width (pixel sized), save the desktop, then
>  > restart emacs and restore the desktop.
>  >
>  > At this point you’ll have a pixel width in your frame parameters.
>  >
>  > Then if you resize the frame to be a multiple of the font-width and
>  > save the desktop, you end up writing the previous pixel widths because
>  > they were in frame parameters and we do not reset them unless you are
>  > using a non-multiple of the font width.
>  >
>  > If that doesn’t make sense I can try and write up a repro when I get a chance.
> 
> Thanks, I understand now.  I'm afraid it's the implementation that
> doesn't make sense but your patch does and should be applied.  I'm not
> sure whether we still can do that on the release branch.  Eli?

Not sure about the release branch.  AFAIU, this problem existed since
Emacs 24.4, and it rears its ugly head only in the situation described
above, where the frame is restored with pixel size that's not a
multiple of the default font, and then resized to be an exact multiple
before saving it, is that right?  If so, it sounds obscure enough for
us to be able to live with it until Emacs 27, I think.





  reply	other threads:[~2018-01-20 10:50 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-17  1:24 bug#30141: 26.0.91; text-pixel dimensions not properly saved by desktop-save-mode sometimes Aaron Jensen
2018-01-17  5:43 ` bug#30141: (26.0.91; text-pixel dimensions not properly saved by desktop-save-mode sometimes) Aaron Jensen
2018-01-17  8:49   ` Robert Pluim
2018-01-17 11:45     ` Aaron Jensen
2018-01-17  9:12   ` martin rudalics
2018-01-17 11:50     ` Aaron Jensen
2018-01-17 11:59       ` Aaron Jensen
2018-01-19 18:55       ` martin rudalics
2018-01-19 19:00         ` Aaron Jensen
2018-01-20 10:35           ` martin rudalics
2018-01-20 10:50             ` Eli Zaretskii [this message]
2018-01-20 14:07               ` martin rudalics
2018-01-20 14:33                 ` Eli Zaretskii
2018-01-22  9:54                   ` martin rudalics
2018-02-13 10:23                     ` martin rudalics
2018-03-12 22:18           ` Aaron Jensen
2018-03-13  7:26             ` martin rudalics
2018-03-13 15:32               ` Aaron Jensen
2018-03-14  8:14                 ` martin rudalics
2018-03-14 14:59                   ` Aaron Jensen
2018-03-14 15:15                     ` Aaron Jensen
2018-03-14 20:05                       ` martin rudalics
2018-03-14 20:12                         ` Aaron Jensen
2018-03-15  8:20                           ` martin rudalics
2018-03-15 15:24                             ` Aaron Jensen
2018-03-17 10:05                               ` martin rudalics
2018-03-17 10:11                                 ` Noam Postavsky
2018-03-17 11:08                                   ` martin rudalics
2018-03-17 11:16                                     ` Eli Zaretskii
2018-03-17 11:28                                       ` martin rudalics
2018-03-17 16:32                                 ` Aaron Jensen
2018-01-17  9:12 ` bug#30141: 26.0.91; text-pixel dimensions not properly saved by desktop-save-mode sometimes martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zi58st1d.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=30141@debbugs.gnu.org \
    --cc=aaronjensen@gmail.com \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).