From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow Date: Tue, 13 Feb 2018 07:40:27 +0200 Message-ID: <83zi4dxx9w.fsf@gnu.org> References: <87d28rt4jl.fsf@telefonica.net> <874lmxloo1.fsf@mail.linkov.net> <83fu692jdu.fsf@gnu.org> <87lgg0sgbz.fsf@mail.linkov.net> <83bmgv1ol3.fsf@gnu.org> <873727xxvf.fsf@linux-m68k.org> <8360731lr9.fsf@gnu.org> <87d11bwfly.fsf@linux-m68k.org> <83y3jzz7hr.fsf@gnu.org> <87vaf3cjbg.fsf@mail.linkov.net> <83bmguyt9w.fsf@gnu.org> <87h8qlubb4.fsf@mail.linkov.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1518500364 19629 195.159.176.226 (13 Feb 2018 05:39:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 13 Feb 2018 05:39:24 +0000 (UTC) Cc: 19045@debbugs.gnu.org, schwab@linux-m68k.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 13 06:39:19 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1elTJ4-00042f-Hh for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Feb 2018 06:39:06 +0100 Original-Received: from localhost ([::1]:45570 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elTL6-0005Q0-7W for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Feb 2018 00:41:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elTKz-0005PK-Rt for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2018 00:41:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elTKw-0001yw-N4 for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2018 00:41:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60702) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1elTKw-0001yo-JQ for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2018 00:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1elTKw-0003RP-CY for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2018 00:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Feb 2018 05:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19045 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19045-submit@debbugs.gnu.org id=B19045.151850044813200 (code B ref 19045); Tue, 13 Feb 2018 05:41:02 +0000 Original-Received: (at 19045) by debbugs.gnu.org; 13 Feb 2018 05:40:48 +0000 Original-Received: from localhost ([127.0.0.1]:40366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1elTKh-0003Qp-Mm for submit@debbugs.gnu.org; Tue, 13 Feb 2018 00:40:47 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:49288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1elTKg-0003Qd-8L for 19045@debbugs.gnu.org; Tue, 13 Feb 2018 00:40:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elTKX-0001ss-RY for 19045@debbugs.gnu.org; Tue, 13 Feb 2018 00:40:40 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35446) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elTKX-0001so-NS; Tue, 13 Feb 2018 00:40:37 -0500 Original-Received: from [176.228.60.248] (port=3413 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1elTKW-00037R-W3; Tue, 13 Feb 2018 00:40:37 -0500 In-reply-to: <87h8qlubb4.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 12 Feb 2018 23:50:55 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143242 Archived-At: > From: Juri Linkov > Cc: schwab@linux-m68k.org, 19045@debbugs.gnu.org > Date: Mon, 12 Feb 2018 23:50:55 +0200 > > > Even if it's true, it means --follow doesn't do any harm when invoked > > on directories, and we shouldn't disallow that. > > I don't know the reason why disallowing directories was implemented > in the first place. Maybe ‘git log --follow’ failed on directories > in some older git versions? Wouldn't it be safer to leave the code > that checks for directories and doesn't add ‘--follow’ for this case? Sorry, I was confused and thought that you also added the non-directory restriction. I agree that we should not modify the code that checks for directories, certainly not on the release branch. Thanks.