From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: 30757@debbugs.gnu.org, npostavs@gmail.com
Subject: bug#30757: Better manipulation (suppressing, examining type) of warnings from *Warnings* buffer
Date: Fri, 09 Mar 2018 18:18:32 +0200 [thread overview]
Message-ID: <83zi3husrr.fsf@gnu.org> (raw)
In-Reply-To: <873719kzyh.fsf@gmail.com> (message from Robert Pluim on Fri, 09 Mar 2018 16:53:26 +0100)
> From: Robert Pluim <rpluim@gmail.com>
> Date: Fri, 09 Mar 2018 16:53:26 +0100
> Cc: 30757@debbugs.gnu.org
>
> Here's what I've got so far. Suggestions welcome for wording, style
> changes, etc.
Thanks.
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -71,6 +71,12 @@ moved to the early init file (see above).
> \f
> * Changes in Emacs 27.1
>
> ++++
"+++" means this change was documented in the manual(s), but this
change wasn't, AFAIU. Shkuld this be documented in the ELisp manual?
> +** Warning types can now be disabled from the warning buffer.
> +For each warning 'display-warning' now adds buttons to the buffer it
> +uses to allow permanent suppression of the warning popup or of the
> +warning itself.
This entry should be made more clear. "Warning types" is never
explained, the reference to 'display-warning' is confusing (this is a
user-level feature, so why mention the function which is involved?),
it is unclear what buffer is alluded to by "the buffer it uses", and
the difference between "warning popup" and "warning itself" is left
unexplained.
> +(define-button-type 'warning-suppress-warning
> + 'action #'warning-suppress-action
> + 'help-echo "mouse-2, RET: Permanently disable popping up this warning")
> +(defun warning-suppress-action (button)
> + (customize-save-variable 'warning-suppress-types
> + (cons (list (button-get button 'warning-type))
> + warning-suppress-types)))
> +(define-button-type 'warning-suppress-log-warning
> + 'action #'warning-suppress-log-action
> + 'help-echo "mouse-2, RET: Never generate this warning")
Likewise here: the difference between "disable popping up" and "never
generate" is unclear. maybe a different wording will clarify that,
but I cannot suggest one because frankly I don't understand well
enough what each one does.
next prev parent reply other threads:[~2018-03-09 16:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 12:31 bug#30757: Better manipulation (suppressing, examining type) of warnings from *Warnings* buffer Noam Postavsky
2018-03-09 14:11 ` Robert Pluim
2018-03-09 14:24 ` Robert Pluim
2018-03-09 14:53 ` Noam Postavsky
2018-03-09 15:53 ` Robert Pluim
2018-03-09 16:18 ` Eli Zaretskii [this message]
2018-03-09 16:54 ` Robert Pluim
2018-03-09 18:28 ` Eli Zaretskii
2018-03-10 3:14 ` Noam Postavsky
2018-03-12 11:04 ` Robert Pluim
2020-09-04 4:30 ` Lars Ingebrigtsen
2020-09-04 8:54 ` Robert Pluim
2020-09-04 11:22 ` Lars Ingebrigtsen
2018-03-09 15:05 ` Drew Adams
2018-03-09 15:49 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zi3husrr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=30757@debbugs.gnu.org \
--cc=npostavs@gmail.com \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).