unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 30938@debbugs.gnu.org
Subject: bug#30938: 27.0; `dired-do-create-files' etc.: do NOT always raise error if no files
Date: Sun, 25 Mar 2018 19:50:41 +0300	[thread overview]
Message-ID: <83zi2wf6am.fsf@gnu.org> (raw)
In-Reply-To: <7ea429b5-b12e-4639-9d77-11db71504d9c@default> (message from Drew Adams on Sun, 25 Mar 2018 09:36:08 -0700 (PDT))

> Date: Sun, 25 Mar 2018 09:36:08 -0700 (PDT)
> From: Drew Adams <drew.adams@oracle.com>
> 
> The bug is that calls to `dired-get-marked-files' have been changed all
> over the place to systematically pass a non-nil value for optional arg
> ERROR.  In general, this is completely inappropriate when the command
> invoking `dired-get-marked-files' is not called interactively.
> 
> There is NO reason to suppose that a `user-error' occurred when a given
> command is invoked non-interactively.
> 
> The logic behind this change is wrong - much too simplistic.  A non-nil
> ERROR arg should perhaps be passed when called from some commands, but
> typically only when such a command is called interactively.  Only then
> might Emacs legitimately assume (and even this is arguable, in general)
> that the user has committed an error.

Please provide at least one example (preferably more than one) of a
real-life use case where these changes get in the way.





      parent reply	other threads:[~2018-03-25 16:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-25 16:36 bug#30938: 27.0; `dired-do-create-files' etc.: do NOT always raise error if no files Drew Adams
2018-03-25 16:45 ` Drew Adams
2018-03-28 20:27   ` Juri Linkov
2018-03-28 23:45     ` Drew Adams
2018-03-29 20:04       ` Juri Linkov
2018-03-29 20:25         ` Noam Postavsky
2018-03-30  4:01           ` Drew Adams
2018-03-30  4:01         ` Drew Adams
2018-03-30  7:57           ` Eli Zaretskii
2018-04-02 19:30           ` Juri Linkov
2022-04-21 13:20             ` Lars Ingebrigtsen
2022-04-21 15:01               ` Drew Adams
     [not found]         ` <<8111e8b0-a7fb-4de4-9371-fd69c74c46e5@default>
     [not found]           ` <<83lgeac7xs.fsf@gnu.org>
2018-03-30 15:01             ` Drew Adams
2018-03-30 15:30               ` Eli Zaretskii
     [not found]         ` <<<8111e8b0-a7fb-4de4-9371-fd69c74c46e5@default>
     [not found]           ` <<<83lgeac7xs.fsf@gnu.org>
     [not found]             ` <<ea1c9d9f-2405-4377-bd42-de7f020cf9d4@default>
     [not found]               ` <<83k1tt8ttp.fsf@gnu.org>
2018-03-30 15:43                 ` Drew Adams
2018-03-30 16:07                   ` Eli Zaretskii
     [not found]         ` <<<<8111e8b0-a7fb-4de4-9371-fd69c74c46e5@default>
     [not found]           ` <<<<83lgeac7xs.fsf@gnu.org>
     [not found]             ` <<<ea1c9d9f-2405-4377-bd42-de7f020cf9d4@default>
     [not found]               ` <<<83k1tt8ttp.fsf@gnu.org>
     [not found]                 ` <<ceb6e79f-5f03-45a5-a7a4-5fe954661d5d@default>
     [not found]                   ` <<83in9d8s4b.fsf@gnu.org>
2018-03-30 17:12                     ` Drew Adams
2018-03-31  9:07                       ` Eli Zaretskii
     [not found]         ` <<<<<8111e8b0-a7fb-4de4-9371-fd69c74c46e5@default>
     [not found]           ` <<<<<83lgeac7xs.fsf@gnu.org>
     [not found]             ` <<<<ea1c9d9f-2405-4377-bd42-de7f020cf9d4@default>
     [not found]               ` <<<<83k1tt8ttp.fsf@gnu.org>
     [not found]                 ` <<<ceb6e79f-5f03-45a5-a7a4-5fe954661d5d@default>
     [not found]                   ` <<<83in9d8s4b.fsf@gnu.org>
     [not found]                     ` <<9b80ae9e-06e3-4217-89b1-eb8a3b0c93b8@default>
     [not found]                       ` <<838ta88vfz.fsf@gnu.org>
2018-03-31 16:10                         ` Drew Adams
2018-03-31 16:50                           ` Eli Zaretskii
2018-03-25 16:50 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zi2wf6am.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=30938@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).