From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 31744@debbugs.gnu.org
Subject: bug#31744: 26.1; Improvements to make tags and make -C test
Date: Fri, 08 Jun 2018 18:38:53 +0300 [thread overview]
Message-ID: <83zi05thiq.fsf@gnu.org> (raw)
In-Reply-To: <87muw72wn8.fsf@gmail.com> (message from Noam Postavsky on Wed, 06 Jun 2018 21:49:47 -0400)
> From: Noam Postavsky <npostavs@gmail.com>
> Date: Wed, 06 Jun 2018 21:49:47 -0400
>
> Some quality-of-life improvements in make targets. I hope these can go
> to emacs-26; although the test/Makefile.in changes aren't bug fixes,
> that file isn't distributed in the tarball.
Thanks for your work on this. A few comments below:
> * src/Makefile.in: Create TAGS files in ${srcdir}, not build dir.
I'm not sure I agree with this. Other projects I looked at produce
TAGS in the build directory (but reference source files in srcdir, of
course). Why do you think TAGS should go to the source directory?
> +ifeq ($(TEST_INTERACTIVE), yes)
> + HOME=/nonexistent $(emacs) \
> + -l ert ${ert_opts} \
> + $(patsubst %,-l %,$(if $(findstring $(TEST_LOAD_EL),yes),$ELFILES,$(ELFILES:.el=))) \
> + $(TEST_RUN_ERT)
> +else
> -@${MAKE} -k ${LOGFILES}
> - @$(emacs) -l ert -f ert-summarize-tests-batch-and-exit ${LOGFILES}
> + @$(emacs) --batch -l ert -f ert-summarize-tests-batch-and-exit ${LOGFILES}
> +endif
Not sure I understand the HOME trick: why not use -Q?
> Subject: [PATCH 4/4] ; Reduce amount of quoting for SELECTOR arg in 'make -C
> test'
>
> Before:
>
> make -C test SELECTOR='\"foo\"'
> make -C test SELECTOR='(quote (tag :some-tag))'
>
> After:
>
> make -C test SELECTOR='"foo"'
> make -C test SELECTOR='(tag :some-tag)'
>
> * test/Makefile.in: Use single quotes around the command line call to
> ert, this means the user doesn't have to backslash escape double
> quotes when writing lisp strings for the selector. Also wrap the
> SELECTOR value in (quote ...) so the user won't have to type it
> in (and not get tempted to use the '... form which would now fail to
> work due to using single quotes around the whole shell arg).
This should be explained in some README in the test suite, I think.
I have no objections to making these changes on the emacs-26 branch.
next prev parent reply other threads:[~2018-06-08 15:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 1:49 bug#31744: 26.1; Improvements to make tags and make -C test Noam Postavsky
2018-06-08 15:38 ` Eli Zaretskii [this message]
2018-06-08 16:04 ` Robert Pluim
2018-06-09 1:12 ` Noam Postavsky
2018-06-09 6:20 ` Eli Zaretskii
2018-06-09 19:16 ` Noam Postavsky
2018-06-10 16:59 ` Eli Zaretskii
2018-06-12 11:49 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zi05thiq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=31744@debbugs.gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).