From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30452: [PATCH] Use 'make-sparse-keymap' rather than 'copy-keymap' Date: Fri, 25 Jan 2019 10:50:29 +0200 Message-ID: <83zhrp5dey.fsf@gnu.org> References: <8736ptiz1b.fsf@gmail.com> <83lg3hax8i.fsf@gnu.org> <877eeyc8hy.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="126149"; mail-complaints-to="usenet@blaine.gmane.org" Cc: monnier@IRO.UMontreal.CA, 30452-done@debbugs.gnu.org To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 25 09:51:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmxCp-000Wim-Ns for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Jan 2019 09:51:19 +0100 Original-Received: from localhost ([127.0.0.1]:40353 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmxCo-00055a-Ks for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Jan 2019 03:51:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmxCf-00054V-Vn for bug-gnu-emacs@gnu.org; Fri, 25 Jan 2019 03:51:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmxCY-0008UF-3l for bug-gnu-emacs@gnu.org; Fri, 25 Jan 2019 03:51:09 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45233) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gmxCY-0008U5-12 for bug-gnu-emacs@gnu.org; Fri, 25 Jan 2019 03:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gmxCX-0007ih-UD for bug-gnu-emacs@gnu.org; Fri, 25 Jan 2019 03:51:01 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Jan 2019 08:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 30452 X-GNU-PR-Package: emacs Mail-Followup-To: 30452@debbugs.gnu.org, eliz@gnu.org, tummychow511@gmail.com Original-Received: via spool by 30452-done@debbugs.gnu.org id=D30452.154840624329643 (code D ref 30452); Fri, 25 Jan 2019 08:51:01 +0000 Original-Received: (at 30452-done) by debbugs.gnu.org; 25 Jan 2019 08:50:43 +0000 Original-Received: from localhost ([127.0.0.1]:44513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gmxCF-0007i3-B9 for submit@debbugs.gnu.org; Fri, 25 Jan 2019 03:50:43 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59333) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gmxCD-0007hq-Co for 30452-done@debbugs.gnu.org; Fri, 25 Jan 2019 03:50:42 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60111) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmxC6-0008H6-0o; Fri, 25 Jan 2019 03:50:34 -0500 Original-Received: from [176.228.60.248] (port=3040 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gmxC5-0002D0-Bk; Fri, 25 Jan 2019 03:50:33 -0500 In-reply-to: <877eeyc8hy.fsf@gmail.com> (message from Alex Branham on Mon, 21 Jan 2019 09:53:29 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154763 Archived-At: > From: Alex Branham > Cc: Eli Zaretskii , 30452@debbugs.gnu.org > Date: Mon, 21 Jan 2019 09:53:29 -0600 > > > On Sat 19 Jan 2019 at 09:33, Stefan Monnier wrote: > > >>> (defvar tabulated-list-mode-map > >>> - (let ((map (copy-keymap special-mode-map))) > >>> + (let ((map (make-sparse-keymap))) > >>> (set-keymap-parent map button-buffer-map) > > > > Nowadays we can inherit from both with something like > > > > (set-keymap-parent map (make-composed-keymap > > button-buffer-map > > special-mode-map)) > > Thanks, that's better! Here's the updated patch. Thanks, pushed to the master branch.