From: Eli Zaretskii <eliz@gnu.org>
To: rms@gnu.org
Cc: 35062@debbugs.gnu.org, hi-angel@yandex.ru
Subject: bug#35062: [PATCH v3 1/3] Remove redundant comparison
Date: Mon, 15 Apr 2019 21:39:35 +0300 [thread overview]
Message-ID: <83zhorgljs.fsf@gnu.org> (raw)
In-Reply-To: <E1hG680-0002jB-SR@fencepost.gnu.org> (message from Richard Stallman on Mon, 15 Apr 2019 14:14:48 -0400)
> From: Richard Stallman <rms@gnu.org>
> Date: Mon, 15 Apr 2019 14:14:48 -0400
> Cc: 35062@debbugs.gnu.org
>
> > IMO in such situations (i.e. when original changes were commited
> > without any modification anyway) would be nice to commit the original
> > patch, and then add up further improvements as 2-nd commit.
>
> That seems ok to me.
I guess you haven't yet read my response where I explained why it
wasn't OK in this case.
next prev parent reply other threads:[~2019-04-15 18:39 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 22:36 bug#35062: Patches: trivial cleanups Konstantin Kharlamov
2019-03-31 22:37 ` bug#35062: [PATCH 0/4] Trivial code cleanups Konstantin Kharlamov
2019-03-31 22:37 ` bug#35062: [PATCH 1/4] Remove redundant comparison Konstantin Kharlamov
2019-03-31 22:37 ` bug#35062: [PATCH 2/4] constify a bit of xterm.c Konstantin Kharlamov
2019-03-31 22:37 ` bug#35062: [PATCH 3/4] min_cols/rows is always 0, don't check for it Konstantin Kharlamov
2019-04-01 22:37 ` Noam Postavsky
2019-04-02 0:09 ` Konstantin Kharlamov
2019-04-02 14:46 ` Eli Zaretskii
2019-04-02 20:54 ` Konstantin Kharlamov
2019-04-03 4:45 ` Eli Zaretskii
2019-04-02 0:23 ` bug#35062: [PATCH v2] min_cols/rows is always 0, remove noop actions Konstantin Kharlamov
2019-04-05 7:05 ` Eli Zaretskii
2019-04-05 22:18 ` Konstantin Kharlamov
2019-04-06 7:09 ` Eli Zaretskii
2019-04-07 2:03 ` Konstantin Kharlamov
2019-04-07 2:45 ` Eli Zaretskii
2019-04-06 7:25 ` Michael Albinus
2019-03-31 22:37 ` bug#35062: [PATCH 4/4] don't compare unsigned to less-than-zero Konstantin Kharlamov
2019-04-01 4:37 ` bug#35062: [PATCH 0/4] Trivial code cleanups Eli Zaretskii
2019-04-01 13:27 ` Robert Pluim
2019-04-01 13:35 ` Konstantin Kharlamov
2019-04-01 13:41 ` Konstantin Kharlamov
2019-04-01 13:43 ` Robert Pluim
2019-04-01 13:51 ` Konstantin Kharlamov
2019-04-01 14:34 ` Eli Zaretskii
2019-04-01 15:04 ` Robert Pluim
2019-04-01 17:37 ` Eli Zaretskii
2019-04-02 20:49 ` bug#35062: [PATCH] Remove redundant multiplication of ch and cw Konstantin Kharlamov
2019-04-05 7:16 ` Eli Zaretskii
2019-04-07 2:13 ` bug#35062: [PATCH v3 1/3] Remove redundant comparison Konstantin Kharlamov
2019-04-07 2:13 ` bug#35062: [PATCH v3 2/3] constify a bit of xterm.c Konstantin Kharlamov
2019-04-13 8:15 ` Eli Zaretskii
2019-04-13 11:30 ` Konstantin Kharlamov
2019-04-13 11:36 ` Eli Zaretskii
2019-04-20 0:31 ` Paul Eggert
2019-04-20 1:09 ` Konstantin Kharlamov
2019-04-20 1:17 ` Konstantin Kharlamov
2019-04-20 6:53 ` Eli Zaretskii
2019-04-20 10:31 ` Konstantin Kharlamov
2019-04-20 11:01 ` Eli Zaretskii
2019-04-20 11:23 ` Konstantin Kharlamov
2019-04-20 11:25 ` Konstantin Kharlamov
2019-04-20 11:47 ` Konstantin Kharlamov
2019-04-20 11:58 ` Konstantin Kharlamov
2019-04-20 6:28 ` Eli Zaretskii
2019-04-07 2:13 ` bug#35062: [PATCH v3 3/3] don't compare unsigned to less-than-zero Konstantin Kharlamov
2019-04-13 8:11 ` Eli Zaretskii
2019-04-13 8:06 ` bug#35062: [PATCH v3 1/3] Remove redundant comparison Eli Zaretskii
2019-04-13 18:19 ` Konstantin Kharlamov
2019-04-13 18:24 ` Eli Zaretskii
2019-04-13 18:28 ` Konstantin Kharlamov
2019-04-13 19:19 ` Eli Zaretskii
2019-04-15 3:38 ` Richard Stallman
2019-04-15 6:49 ` Konstantin Kharlamov
2019-04-15 14:32 ` Eli Zaretskii
2019-04-15 15:01 ` Konstantin Kharlamov
2019-04-15 15:21 ` Eli Zaretskii
2019-04-15 17:03 ` Konstantin Kharlamov
2019-04-15 17:16 ` Eli Zaretskii
2019-04-15 17:29 ` Konstantin Kharlamov
2019-04-15 18:21 ` Eli Zaretskii
2019-04-15 18:14 ` Richard Stallman
2019-04-15 18:39 ` Eli Zaretskii [this message]
2019-04-15 14:25 ` Eli Zaretskii
2019-04-16 21:27 ` Richard Stallman
2019-04-17 2:40 ` Eli Zaretskii
2019-04-17 20:52 ` Richard Stallman
2019-06-23 18:07 ` bug#35062: Patches: trivial cleanups Lars Ingebrigtsen
2019-06-23 18:34 ` Constantine Kharlamov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zhorgljs.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=35062@debbugs.gnu.org \
--cc=hi-angel@yandex.ru \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).