From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36219: GNU Emacs 26.1 --eval rejects trailing whitespace Date: Sat, 15 Jun 2019 17:24:01 +0300 Message-ID: <83zhmjudtq.fsf@gnu.org> References: <87ftobynvt.fsf@gmail.com> <834l4rvtqr.fsf@gnu.org> <87d0jfymch.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="45334"; mail-complaints-to="usenet@blaine.gmane.org" Cc: andpuke@foxmail.com, 36219@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 15 16:25:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hc9cE-000BbV-Bs for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Jun 2019 16:25:10 +0200 Original-Received: from localhost ([::1]:60820 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hc9cD-0004u4-4t for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Jun 2019 10:25:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50690) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hc9c7-0004tx-ON for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2019 10:25:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hc9c6-00037h-QC for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2019 10:25:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53749) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hc9c6-00037W-MK for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2019 10:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hc9c6-0001Rr-H1 for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2019 10:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jun 2019 14:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36219 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36219-submit@debbugs.gnu.org id=B36219.15606086465492 (code B ref 36219); Sat, 15 Jun 2019 14:25:02 +0000 Original-Received: (at 36219) by debbugs.gnu.org; 15 Jun 2019 14:24:06 +0000 Original-Received: from localhost ([127.0.0.1]:39060 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hc9bC-0001QV-6n for submit@debbugs.gnu.org; Sat, 15 Jun 2019 10:24:06 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hc9bA-0001Pw-0f for 36219@debbugs.gnu.org; Sat, 15 Jun 2019 10:24:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37459) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hc9b1-0002HE-CY; Sat, 15 Jun 2019 10:23:55 -0400 Original-Received: from [176.228.60.248] (port=2249 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hc9b0-0002pE-OU; Sat, 15 Jun 2019 10:23:55 -0400 In-reply-to: <87d0jfymch.fsf@gmail.com> (message from Noam Postavsky on Sat, 15 Jun 2019 10:06:22 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160615 Archived-At: > From: Noam Postavsky > Cc: andpuke@foxmail.com, 36219@debbugs.gnu.org > Date: Sat, 15 Jun 2019 10:06:22 -0400 > > Eli Zaretskii writes: > > >> I think I'd prefer checking the trailing garbage for whitespace, which > >> is what eval-expression does. See following patch: > > > > SGTM, thanks. > > Not sure if you missed my question about emacs-26 (it was below the > patch, maybe a bad place to put it) > > This is a regression from Emacs 25, and the fix looks pretty safe to me; > although the bug isn't especially severe. Should it go to emacs-26? I think the fix should go to master.