From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36496: [PATCH] Describe the rx notation in the lisp manual Date: Sat, 06 Jul 2019 22:10:38 +0300 Message-ID: <83zhlr6ksx.fsf@gnu.org> References: <0C783D67-9502-408B-B845-5599BD596361@acm.org> <838stdbw8e.fsf@gnu.org> <83r2738r9j.fsf@gnu.org> <83k1cv8k5z.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="186127"; mail-complaints-to="usenet@blaine.gmane.org" Cc: npostavs@gmail.com, 36496@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 06 21:11:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hjq5V-000mHH-Ag for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Jul 2019 21:11:09 +0200 Original-Received: from localhost ([::1]:32810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjq5T-0004RD-TN for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Jul 2019 15:11:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43838) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjq5P-0004Qr-1p for bug-gnu-emacs@gnu.org; Sat, 06 Jul 2019 15:11:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hjq5O-0004aH-2B for bug-gnu-emacs@gnu.org; Sat, 06 Jul 2019 15:11:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47085) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hjq5N-0004a9-UJ for bug-gnu-emacs@gnu.org; Sat, 06 Jul 2019 15:11:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hjq5N-0001N6-N2 for bug-gnu-emacs@gnu.org; Sat, 06 Jul 2019 15:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Jul 2019 19:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36496 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36496-submit@debbugs.gnu.org id=B36496.15624402525251 (code B ref 36496); Sat, 06 Jul 2019 19:11:01 +0000 Original-Received: (at 36496) by debbugs.gnu.org; 6 Jul 2019 19:10:52 +0000 Original-Received: from localhost ([127.0.0.1]:55906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjq5D-0001Mc-Mu for submit@debbugs.gnu.org; Sat, 06 Jul 2019 15:10:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjq5B-0001MQ-F5 for 36496@debbugs.gnu.org; Sat, 06 Jul 2019 15:10:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57944) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hjq56-0004NK-2D; Sat, 06 Jul 2019 15:10:44 -0400 Original-Received: from [176.228.60.248] (port=4574 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hjq55-000409-D2; Sat, 06 Jul 2019 15:10:43 -0400 In-reply-to: (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Sat, 6 Jul 2019 20:56:57 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162254 Archived-At: > From: Mattias EngdegÄrd > Date: Sat, 6 Jul 2019 20:56:57 +0200 > Cc: 36496@debbugs.gnu.org > > >> * lisp/emacs-lisp/rx.el (rx): Replace long description with a condensed > >> summary of the rx syntax, with reference to the manual section. > > > > This is OK, but it is inconsistent wrt whether each construct's > > description ends in a period. I suggest to end them all with a > > period. > > Added, except at the end of the lists of aliases which looked better with a minimum of punctuation (and weren't sentences to begin with). It still looks jarring: +(seq RX...) Match the RXs in sequence. Alias: :, sequence, and +(or RX...) Match one of the RXs. Alias: | + +(zero-or-more RX...) Match RXs zero or more times. Alias: 0+ +(one-or-more RX...) Match RXs one or more times. Alias: 1+ +(zero-or-one RX...) Match RXs or the empty string. Alias: opt, optional Honestly, they look like incorrect English: a sentence, starting with a capital letter, but not ending with a period. I hope you will reconsider.