From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37641: major/minor tick faces bleed into empty lines at the end of buffer Date: Wed, 09 Oct 2019 13:22:47 +0300 Message-ID: <83zhiausjs.fsf@gnu.org> References: <83zhiczg1m.fsf@gnu.org> <83sgo3y632.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="263161"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37641@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 09 20:12:36 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIGRw-0016Me-Ae for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 20:12:36 +0200 Original-Received: from localhost ([::1]:53632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIGRu-0000gW-Kc for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 14:12:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56252) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iI98V-0001VW-I9 for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 06:24:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iI98U-0008A2-GL for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 06:24:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43352) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iI98U-00089x-DQ for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 06:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iI98U-0005Ak-5g for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 06:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Oct 2019 10:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37641 X-GNU-PR-Package: emacs Original-Received: via spool by 37641-submit@debbugs.gnu.org id=B37641.157061659319826 (code B ref 37641); Wed, 09 Oct 2019 10:24:02 +0000 Original-Received: (at 37641) by debbugs.gnu.org; 9 Oct 2019 10:23:13 +0000 Original-Received: from localhost ([127.0.0.1]:52173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI97g-00059i-Md for submit@debbugs.gnu.org; Wed, 09 Oct 2019 06:23:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI97e-00059T-Rl for 37641@debbugs.gnu.org; Wed, 09 Oct 2019 06:23:11 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38275) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iI97Z-0007x2-OY; Wed, 09 Oct 2019 06:23:05 -0400 Original-Received: from [176.228.60.248] (port=1034 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iI97Z-0005uJ-0E; Wed, 09 Oct 2019 06:23:05 -0400 In-reply-to: (message from Juanma Barranquero on Tue, 8 Oct 2019 12:47:22 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168735 Archived-At: > From: Juanma Barranquero > Date: Tue, 8 Oct 2019 12:47:22 +0200 > Cc: 37641@debbugs.gnu.org > > Turns out there's a difference after all. See the attached images. If you move the > cursor past the EOB, with the beyond_zv check the line is drawn with the line-number > face, not the line-number-current-line face. If we check with it->what != IT_EOB, > then the line-number-current-line face is used. > > I think the right thing to do, when dealing with the "phantom line" just past the EOB, > is to: > - Use line-number-current-line, if the cursor is there. > - Use the line-number face, and not the tick faces, if the cursor is not, regardless > of whether this phantom line would be a tick line or not if it were used. Agreed. > So there's a patch that checks for tick faces with beyond_zv, for the current line > face with it->what, and that moves all face setting for line numbers entirely out of > the loop. LGTM, thanks.