From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Date: Sun, 24 Nov 2019 18:05:10 +0200 Message-ID: <83zhgls1jd.fsf@gnu.org> References: <87ftj5at1q.fsf@gnus.org> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87d0di7959.fsf@linkov.net> <7115df2d-c209-c672-7e92-ff682c4ec8ee@yandex.ru> <87mucm43ja.fsf@mail.linkov.net> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="135822"; mail-complaints-to="usenet@blaine.gmane.org" Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, dgutov@yandex.ru To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 25 16:30:40 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iZGJy-000ZA3-Nw for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Nov 2019 16:30:38 +0100 Original-Received: from localhost ([::1]:45310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZGJx-0000kq-0H for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Nov 2019 10:30:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60460) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZGJQ-0000jo-G6 for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 10:30:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZGJP-0004Qh-F0 for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 10:30:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43593) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZGJP-0004Qb-Bs for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 10:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iZGJP-0001TQ-8N for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 10:30:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Nov 2019 15:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38044 X-GNU-PR-Package: emacs Original-Received: via spool by 38044-submit@debbugs.gnu.org id=B38044.15746957605560 (code B ref 38044); Mon, 25 Nov 2019 15:30:03 +0000 Original-Received: (at 38044) by debbugs.gnu.org; 25 Nov 2019 15:29:20 +0000 Original-Received: from localhost ([127.0.0.1]:49555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZGIi-0001RX-Gt for submit@debbugs.gnu.org; Mon, 25 Nov 2019 10:29:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51245) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZGIb-0001QJ-5O for 38044@debbugs.gnu.org; Mon, 25 Nov 2019 10:29:13 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49954) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iYuNr-0005n2-U6; Sun, 24 Nov 2019 11:05:11 -0500 Original-Received: from [176.228.60.248] (port=1273 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iYuNq-0008HP-1y; Sun, 24 Nov 2019 11:05:11 -0500 In-reply-to: <87mucm43ja.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 24 Nov 2019 00:43:37 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172368 Archived-At: > From: Juri Linkov > Cc: Eli Zaretskii , larsi@gnus.org, stephen.berman@gmx.net, > 38044@debbugs.gnu.org > Date: Sun, 24 Nov 2019 00:43:37 +0200 > > @@ -2416,7 +2416,10 @@ vc-log-internal-common > (let ((inhibit-read-only t)) > ;; log-view-mode used to be called with inhibit-read-only bound > ;; to t, so let's keep doing it, just in case. > - (vc-call-backend backend 'log-view-mode) > + (vc-call-backend backend > + (if (eq type 'with-diff) > + 'region-history-mode > + 'log-view-mode)) Can we avoid calling region-history-mode if the backend doesn't implement it? Or do you plan on adding that to all backends? Thanks.