From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38796: 26.3; `view-lossage': Use a variable for the lossage limit Date: Sun, 29 Dec 2019 19:30:15 +0200 Message-ID: <83zhfbm448.fsf@gnu.org> References: <43aac56d-ecf1-44ed-9be1-ffb8e5f8a7ce@default> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="140286"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38796@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 29 18:32:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ilcQB-000aML-RB for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Dec 2019 18:32:08 +0100 Original-Received: from localhost ([::1]:53884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ilcQA-0005xI-HO for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Dec 2019 12:32:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43306) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ilcPA-0005OD-AN for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 12:31:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ilcP9-0000Hs-7K for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 12:31:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54203) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ilcP9-0000HW-3X for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 12:31:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ilcP9-0002QL-1E for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 12:31:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Dec 2019 17:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38796 X-GNU-PR-Package: emacs Original-Received: via spool by 38796-submit@debbugs.gnu.org id=B38796.15776406468440 (code B ref 38796); Sun, 29 Dec 2019 17:31:02 +0000 Original-Received: (at 38796) by debbugs.gnu.org; 29 Dec 2019 17:30:46 +0000 Original-Received: from localhost ([127.0.0.1]:60174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilcOs-0002Bg-AE for submit@debbugs.gnu.org; Sun, 29 Dec 2019 12:30:46 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:32889) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilcOq-00025j-9B; Sun, 29 Dec 2019 12:30:44 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ilcOk-0007d3-Js; Sun, 29 Dec 2019 12:30:39 -0500 Original-Received: from [176.228.60.248] (port=3875 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ilcOJ-0001pt-Pg; Sun, 29 Dec 2019 12:30:34 -0500 In-reply-to: <43aac56d-ecf1-44ed-9be1-ffb8e5f8a7ce@default> (message from Drew Adams on Sun, 29 Dec 2019 09:04:54 -0800 (PST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173898 Archived-At: severity 38796 wishlist thanks > Date: Sun, 29 Dec 2019 09:04:54 -0800 (PST) > From: Drew Adams > > This report is a follow-up to this emacs-devel thread: > > https://lists.gnu.org/archive/html/emacs-devel/2019-12/msg00678.html > > and to the older thread that it references: > > https://lists.gnu.org/archive/html/emacs-devel/2006-03/msg01012.html > > Please use a variable for the limit of how many characters to use for > recording lossage. > > Doing that will give users (and Lisp code) control over the limit. > Having a limit that is hard-coded in C is not user-friendly - it's even > unemacsy. It's a constant size of a vector that records the keys in a cyclical fashion. So it isn't enough to expose the value to Lisp; one must also write code that reallocates the vector when the value changes, and copies the keystrokes from the old to the new vector in the correct order. Not rocket science, but still. Patches are welcome.