From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41645: 27.0.91; Combining Grapheme Joiner (#x34f) gui artifacts Date: Thu, 04 Jun 2020 05:36:36 +0300 Message-ID: <83zh9jblqj.fsf@gnu.org> References: <83zh9merd4.fsf@gnu.org> <83wo4qepab.fsf@gnu.org> <83lfl6eiod.fsf@gnu.org> <83zh9lcuyg.fsf@gnu.org> <87o8q1xohw.fsf@gmail.com> <83d06gcjtp.fsf@gnu.org> <87d06g6vsw.fsf@gmail.com> <834krscfa3.fsf@gnu.org> <87v9k76gq4.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="57855"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dfussner@googlemail.com, 41645@debbugs.gnu.org To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 04 04:37:27 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jgfl1-000EvL-3D for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jun 2020 04:37:27 +0200 Original-Received: from localhost ([::1]:47976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgfky-0005r5-DG for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Jun 2020 22:37:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44660) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgfkc-0005qi-IV for bug-gnu-emacs@gnu.org; Wed, 03 Jun 2020 22:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33299) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jgfkc-0004vU-9z for bug-gnu-emacs@gnu.org; Wed, 03 Jun 2020 22:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jgfkc-0001ph-6J for bug-gnu-emacs@gnu.org; Wed, 03 Jun 2020 22:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jun 2020 02:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41645 X-GNU-PR-Package: emacs Original-Received: via spool by 41645-submit@debbugs.gnu.org id=B41645.15912382207036 (code B ref 41645); Thu, 04 Jun 2020 02:37:02 +0000 Original-Received: (at 41645) by debbugs.gnu.org; 4 Jun 2020 02:37:00 +0000 Original-Received: from localhost ([127.0.0.1]:44845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgfkZ-0001pQ-NT for submit@debbugs.gnu.org; Wed, 03 Jun 2020 22:36:59 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgfkX-0001pB-Am for 41645@debbugs.gnu.org; Wed, 03 Jun 2020 22:36:58 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53141) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgfkS-0004uO-0W; Wed, 03 Jun 2020 22:36:52 -0400 Original-Received: from [176.228.60.248] (port=3768 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jgfkR-0005d1-FV; Wed, 03 Jun 2020 22:36:51 -0400 In-Reply-To: <87v9k76gq4.fsf@gmail.com> (message from Pip Cet on Wed, 03 Jun 2020 20:23:47 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181488 Archived-At: > From: Pip Cet > Cc: dfussner@googlemail.com, 41645@debbugs.gnu.org > Date: Wed, 03 Jun 2020 20:23:47 +0000 > > diff --git a/src/xdisp.c b/src/xdisp.c > index 0f06a38d40..414dc8809b 100644 > --- a/src/xdisp.c > +++ b/src/xdisp.c > @@ -30592,6 +30592,12 @@ gui_produce_glyphs (struct it *it) > it->glyph_row->contains_overlapping_glyphs_p = true; > > it->pixel_width = cmp->pixel_width; > + if (it->pixel_width == 0) > + { > + /* We assure that all visible glyphs have at least 1-pixel > + width. */ > + it->pixel_width = 1; > + } > it->ascent = it->phys_ascent = cmp->ascent; > it->descent = it->phys_descent = cmp->descent; > IT_APPLY_FACE_BOX(it, face); > @@ -30623,6 +30629,12 @@ gui_produce_glyphs (struct it *it) > it->pixel_width > = composition_gstring_width (gstring, it->cmp_it.from, it->cmp_it.to, > &metrics); > + if (it->pixel_width == 0) > + { > + /* We assure that all visible glyphs have at least 1-pixel > + width. */ > + it->pixel_width = 1; > + } > if (it->glyph_row > && (metrics.lbearing < 0 || metrics.rbearing > metrics.width)) > it->glyph_row->contains_overlapping_glyphs_p = true; I like this less than your original proposal. Artificially "fixing" the pixel width of a glyph without changing anything else might get us in trouble, since the font glyph is still zero-width and its other metrics are incompatible with this "fixed" value. Why did you prefer this to the original proposal, which was to set the font_not_found_p flag?