From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#5042: bug#9917: 24.0.90; Make `goto-line' consistent with the line number from the minibuffer Date: Sat, 19 Sep 2020 21:33:59 +0300 Message-ID: <83zh5l1uqw.fsf@gnu.org> References: <877dspmzo3.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22977"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmoncayo@gmail.com, 9917@debbugs.gnu.org, monnier@iro.umontreal.ca, 5042@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 19 20:35:37 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJhhw-0005qu-Nm for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Sep 2020 20:35:36 +0200 Original-Received: from localhost ([::1]:56600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJhhv-0002S0-Of for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Sep 2020 14:35:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50262) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJhhU-0002QH-9C for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 14:35:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36566) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJhhO-00009k-HW for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 14:35:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJhhO-0005fw-Et for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 14:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Sep 2020 18:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5042 X-GNU-PR-Package: emacs Original-Received: via spool by 5042-submit@debbugs.gnu.org id=B5042.160054045421750 (code B ref 5042); Sat, 19 Sep 2020 18:35:02 +0000 Original-Received: (at 5042) by debbugs.gnu.org; 19 Sep 2020 18:34:14 +0000 Original-Received: from localhost ([127.0.0.1]:48110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJhgc-0005ei-2O for submit@debbugs.gnu.org; Sat, 19 Sep 2020 14:34:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJhgZ-0005eR-NG; Sat, 19 Sep 2020 14:34:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49958) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJhgR-0008Uq-Ui; Sat, 19 Sep 2020 14:34:05 -0400 Original-Received: from [176.228.60.248] (port=1559 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kJhgR-0003ka-F7; Sat, 19 Sep 2020 14:34:03 -0400 In-Reply-To: <877dspmzo3.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 19 Sep 2020 19:42:04 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188428 Archived-At: > From: Lars Ingebrigtsen > Date: Sat, 19 Sep 2020 19:42:04 +0200 > Cc: 9917@debbugs.gnu.org, Stefan Monnier , > 5042@debbugs.gnu.org > > Dani Moncayo writes: > > > This discrepancy is quite confusing for users, so my proposal is > > obvious: adjust the behaviour of `goto-line' to make it consistent > > with the line number showed in the minibuffer, i.e, to consider its > > LINE argument relative to the narrowed part if there's one, or else to > > the whole buffer. > > The suggestion here is to make the interactive `goto-line' go to the > narrowed-to line instead of the absolute line. I can see the reasoning > here -- especially after `display-line-numbers-mode' was added, > displaying line numbers seems to be getting more popular, and having > `M-x goto-char' not going to the number you're seeing (if the buffer is > narrowed) sounds confusing. > > But it is a breaking change -- somewhat. `goto-line' isn't supposed to > be used in code, and isn't used in-tree, but who knows what people have > done out there... The alternative POV, whereby line numbers are absolute disregarding the narrowing, is also valid. What's more important, it was there first. So I think it has to be a different command. If someone wants to rebind "M-g g" to that new command, they can always do that.