From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#44068: 28.0.50; Faulty uses of tabulated-list-format Date: Mon, 19 Oct 2020 16:52:09 +0300 Message-ID: <83zh4ipbli.fsf@gnu.org> References: <87imb7e242.fsf@gmx.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5424"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44068@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 19 15:53:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kUVb3-0001Iy-87 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Oct 2020 15:53:09 +0200 Original-Received: from localhost ([::1]:55890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUVb1-0004U0-WE for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Oct 2020 09:53:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49140) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUVaw-0004Te-3K for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2020 09:53:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57001) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUVav-00007w-Py for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2020 09:53:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kUVav-0006BI-PQ for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2020 09:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Oct 2020 13:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44068 X-GNU-PR-Package: emacs Original-Received: via spool by 44068-submit@debbugs.gnu.org id=B44068.160311553323692 (code B ref 44068); Mon, 19 Oct 2020 13:53:01 +0000 Original-Received: (at 44068) by debbugs.gnu.org; 19 Oct 2020 13:52:13 +0000 Original-Received: from localhost ([127.0.0.1]:40314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUVa9-0006A4-Fh for submit@debbugs.gnu.org; Mon, 19 Oct 2020 09:52:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUVa7-00069p-0i for 44068@debbugs.gnu.org; Mon, 19 Oct 2020 09:52:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34265) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUVa1-0008Tl-JA; Mon, 19 Oct 2020 09:52:05 -0400 Original-Received: from [176.228.60.248] (port=2144 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kUVa0-0008GJ-Kq; Mon, 19 Oct 2020 09:52:05 -0400 In-Reply-To: <87imb7e242.fsf@gmx.net> (message from Stephen Berman on Sun, 18 Oct 2020 22:00:13 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190985 Archived-At: > From: Stephen Berman > Date: Sun, 18 Oct 2020 22:00:13 +0200 > > On trying out the new tabulated-list implementation of the bookmarks > list I noticed that, when clicking on the File header, the sort > indicator is not displayed, unlike with the Bookmark header. Then I > noticed that the same thing happens in the tabulated buffer list (C-x > C-b). Then I grepped for all uses of tabulated-list-format in the Emacs > sources and found the same problem in most of them. The reason is that > in these modes the width of at least one of the columns is too narrow, > so that tabulated-list-init-header omits the indicator. In most cases > the problematic column is the final one, but in a couple of cases there > are also non-final too narrow columns. And I think these bugs are due > to a misleading description in tabulated-list-format's doc string. The > attached patch corrects the doc string and the problematic uses of > tabulated-list-format. The patch also fixes a typo and tries to improve > column alignment in timer-list-mode: this is one of the few modes > derived from tabulated-list-mode whose column widths didn't need to be > corrected, but the alignment seemed suboptimal; however, when the header > line uses a variable-pitch face, the alignment is still suboptimal even > with the patch, and I don't know how to fix that. Instead of manually fine-tuning each column's width, wouldn't it be better to use the string-trim capabilities that replace excess characters with an ellipsis? Thanks.