unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#47879: [PATCH] Ignore mode hooks when analysing diffs
@ 2021-04-18 19:08 Philip Kaludercic
  2021-04-18 19:25 ` Eli Zaretskii
  2021-04-18 20:18 ` Philipp Stephani
  0 siblings, 2 replies; 10+ messages in thread
From: Philip Kaludercic @ 2021-04-18 19:08 UTC (permalink / raw)
  To: 47879

[-- Attachment #1: Type: text/plain, Size: 643 bytes --]


This fixes a bug related to log-edit-generate-changelog-from-diff.

When I tried to invoke this command in a commit buffer, the error

     signal: Unmatched bracket or quote

was raised. The reason was that I added paredit-mode to
emacs-lisp-mode-hook, that when invoked calls check-parens. This raises
an error when the diff contains a partial s-expression, which is almost
always the case.

The least invasive approach I could come up with was to defer the mode
hooks. Most hooks should not have any effect on what
diff-add-log-current-defuns is doing, but I'm not sure if there are any
exceptions that I didn't think of.

-- 
	Philip K.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0003-Avoid-calling-mode-hook-when-analysing-diff.patch --]
[-- Type: text/x-diff, Size: 1083 bytes --]

From 6ce025a1c61912ee20083271e821878f049ac801 Mon Sep 17 00:00:00 2001
From: Philip K <philipk@posteo.net>
Date: Sun, 18 Apr 2021 20:40:16 +0200
Subject: [PATCH 3/4] Avoid calling mode hook when analysing diff

Author:
---
 lisp/vc/diff-mode.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/vc/diff-mode.el b/lisp/vc/diff-mode.el
index 2c72c45f4b..0b77ed11bc 100644
--- a/lisp/vc/diff-mode.el
+++ b/lisp/vc/diff-mode.el
@@ -2334,7 +2334,8 @@ diff-add-log-current-defuns
                         (if other-buf (set-buffer other-buf)
                           (set-buffer (generate-new-buffer " *diff-other-text*"))
                           (insert (if applied old-text new-text))
-                          (funcall (buffer-local-value 'major-mode buf))
+                          (delay-mode-vhooks
+                            (funcall (buffer-local-value 'major-mode buf)))
                           (setq other-buf (current-buffer)))
                         (goto-char (point-min))
                         (forward-line (+ =lines -1
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-05-03 10:28 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-18 19:08 bug#47879: [PATCH] Ignore mode hooks when analysing diffs Philip Kaludercic
2021-04-18 19:25 ` Eli Zaretskii
2021-04-18 20:08   ` Philip Kaludercic
2021-04-21 14:12     ` Stefan Kangas
2021-04-21 14:23       ` Eli Zaretskii
2021-04-21 14:36         ` Philip Kaludercic
2021-04-21 14:45           ` Stefan Kangas
2021-04-21 14:52             ` Philip Kaludercic
2021-05-03 10:28               ` Lars Ingebrigtsen
2021-04-18 20:18 ` Philipp Stephani

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).