From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#47408: [PATCH] Etags support for Mercury -- fix explicit tags for existentially-quantified procedures Date: Fri, 18 Jun 2021 14:29:41 +0300 Message-ID: <83zgvnxvfe.fsf@gnu.org> References: <46bb9128-8bf5-e24c-2172-1cbb4202ee1d@gmail.com> <83lf7c5t6z.fsf@gnu.org> <46a10b9f-91d7-63c4-1513-0af4743e0940@gmail.com> <83eed45omq.fsf@gnu.org> <83y2b8zrxa.fsf@gnu.org> <83wnqszphk.fsf@gnu.org> <768bbdf8-19a9-7401-65a0-9171678c006b@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33403"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47408@debbugs.gnu.org To: fabrice nicol Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 18 13:30:08 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1luChM-0008Xn-LF for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Jun 2021 13:30:08 +0200 Original-Received: from localhost ([::1]:46648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luChL-0001Gh-N2 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Jun 2021 07:30:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luChG-0001GS-81 for bug-gnu-emacs@gnu.org; Fri, 18 Jun 2021 07:30:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44388) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1luChG-0000U1-0J for bug-gnu-emacs@gnu.org; Fri, 18 Jun 2021 07:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1luChF-0007at-TN for bug-gnu-emacs@gnu.org; Fri, 18 Jun 2021 07:30:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Jun 2021 11:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47408 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47408-submit@debbugs.gnu.org id=B47408.162401578429147 (code B ref 47408); Fri, 18 Jun 2021 11:30:01 +0000 Original-Received: (at 47408) by debbugs.gnu.org; 18 Jun 2021 11:29:44 +0000 Original-Received: from localhost ([127.0.0.1]:55934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luCgx-0007a3-Lm for submit@debbugs.gnu.org; Fri, 18 Jun 2021 07:29:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luCgw-0007Zq-CL for 47408@debbugs.gnu.org; Fri, 18 Jun 2021 07:29:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36930) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luCgq-0000M5-9I; Fri, 18 Jun 2021 07:29:36 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1274 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luCgp-0003sI-P7; Fri, 18 Jun 2021 07:29:36 -0400 In-Reply-To: <768bbdf8-19a9-7401-65a0-9171678c006b@gmail.com> (message from fabrice nicol on Thu, 17 Jun 2021 20:36:56 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208690 Archived-At: > Cc: pot@gnu.org, 47408@debbugs.gnu.org > From: fabrice nicol > Date: Thu, 17 Jun 2021 20:36:56 +0200 > > I could finalize my tests against the entire Mercury library code. > > All is OK. I applied your patch on top of mine. > > Also, I added two new corner-case fixes, which are mentioned in the > commit message: > > 1. The first new fix is for 0-arity predicates and functions. Yes, > Mercury has them. (They play the role of global immutable constants in > other languages). > > They happened not to be caught by the previous code, now they are. > > 2. I also removed module names from within tag names. The point is that > module name prefixing is optional in most cases, so if you leave the > module prefix within the tag, you will fail to get to the declaration > when striking M-. on a (non-prefixed) predicate name. It is better to > remove the name altogether. This will automatically trigger an explicit tag. Thanks, installed.