From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#49786: 28.0.50; [PATCH] package-install shouldn't change default-directory Date: Fri, 30 Jul 2021 22:54:02 +0300 Message-ID: <83zgu3poh1.fsf@gnu.org> References: <87h7gb39bt.fsf@dick> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35372"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49786@debbugs.gnu.org To: dick , Ioannis Kappas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 30 21:55:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9Yb7-000929-VE for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Jul 2021 21:55:09 +0200 Original-Received: from localhost ([::1]:33146 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m9Yb6-00065e-KZ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Jul 2021 15:55:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46072) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9Yb0-00065W-9S for bug-gnu-emacs@gnu.org; Fri, 30 Jul 2021 15:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49447) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m9Yb0-0001FG-10 for bug-gnu-emacs@gnu.org; Fri, 30 Jul 2021 15:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m9Yb0-0007xa-15 for bug-gnu-emacs@gnu.org; Fri, 30 Jul 2021 15:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Jul 2021 19:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49786 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49786-submit@debbugs.gnu.org id=B49786.162767486630551 (code B ref 49786); Fri, 30 Jul 2021 19:55:01 +0000 Original-Received: (at 49786) by debbugs.gnu.org; 30 Jul 2021 19:54:26 +0000 Original-Received: from localhost ([127.0.0.1]:60993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9YaQ-0007wh-FX for submit@debbugs.gnu.org; Fri, 30 Jul 2021 15:54:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9YaO-0007wU-IN for 49786@debbugs.gnu.org; Fri, 30 Jul 2021 15:54:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53590) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m9YaJ-0000n4-0Z; Fri, 30 Jul 2021 15:54:19 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2248 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9YaI-0005qQ-Gi; Fri, 30 Jul 2021 15:54:18 -0400 In-Reply-To: <87h7gb39bt.fsf@dick> (message from dick on Fri, 30 Jul 2021 15:12:06 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210943 Archived-At: > From: dick > Date: Fri, 30 Jul 2021 15:12:06 -0400 > > Commit 606b783acb leverages a 2015 hack that extracts the > package version from the buffer file name, only he has to > explicitly `set-visited-file-name` to do it. > > `set-visited-file-name` has the adverse side effect of > changing the default-directory, and that causes me problems. Ioannis, could you please tell why you needed to call set-visited-file-name there? > If the ostensible reason for bug#48137 was to get the "lm" > functions dos-aware, then why not do that instead of applying > a workaround on top of a hack? This was discussed in that bug, and the conclusion was that it's a worse alternative than the solution eventually installed. > * test/lisp/emacs-lisp/package-tests.el (package-test-install-file-EOLs): > What is "mac" encoding? It doesn't work. The names of > salient coding systems do not coincide with the predominant > desktop operating systems. The 'mac' encoding is documented in the ELisp manual. Please don't remove its testing here.