From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#53133: 28.0.90; tabulated-list-sort doesn't work as expected Date: Sun, 09 Jan 2022 13:30:28 +0200 Message-ID: <83zgo516zv.fsf@gnu.org> References: <87k0f9is28.wl-shingo.fg8@gmail.com> <8335lx2npc.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32374"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53133@debbugs.gnu.org To: shingo.fg8@gmail.com, stefankangas@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 09 12:31:38 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n6WQD-0008G8-VX for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Jan 2022 12:31:38 +0100 Original-Received: from localhost ([::1]:41612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n6WQC-0007Ez-2s for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Jan 2022 06:31:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6WPe-0007Dq-SI for bug-gnu-emacs@gnu.org; Sun, 09 Jan 2022 06:31:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56408) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n6WPe-0006nj-JZ for bug-gnu-emacs@gnu.org; Sun, 09 Jan 2022 06:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n6WPe-0006iG-FD for bug-gnu-emacs@gnu.org; Sun, 09 Jan 2022 06:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Jan 2022 11:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53133 X-GNU-PR-Package: emacs Original-Received: via spool by 53133-submit@debbugs.gnu.org id=B53133.164172785025786 (code B ref 53133); Sun, 09 Jan 2022 11:31:02 +0000 Original-Received: (at 53133) by debbugs.gnu.org; 9 Jan 2022 11:30:50 +0000 Original-Received: from localhost ([127.0.0.1]:49311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n6WPR-0006hp-Lb for submit@debbugs.gnu.org; Sun, 09 Jan 2022 06:30:49 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n6WPQ-0006hd-TD for 53133@debbugs.gnu.org; Sun, 09 Jan 2022 06:30:49 -0500 Original-Received: from [2001:470:142:3::e] (port=53120 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6WPL-0006nI-La; Sun, 09 Jan 2022 06:30:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7Lnpqu5Bi6GPQidErV/BUI6bvDy6uZnFi6OK9ppF1YQ=; b=nIPQfYz4EjBb aaJoKEeCmn72vVWhi+ACSsvpqY3eLFhYPTgmluBB1D0DNcEdha6/TCYFxBdu4ol8CCO5wmgelc2uV APsSvTwwqgvn5xk6FjTeB6yHAyQU0qMKe/uGCQvw0B+UpOE3JnHlLF3gNtg1tf+OXuP9xuPdOKcHv +MCJh775vtESt0CO7MtvSSUBPoIPJQgz54NctcdjDqxqjlDF3phOJlL4g8BPMPtGEBOxrUaE0kMrP zz0aD7AB9Ec152E3YgxAWee+MPp3tDp1XYou+yMPOGSDSQ4G/wz0IuljqFihrBDEcWJXSy8YoSXWU jTXXFA7+46ycSjUqYmR87w==; Original-Received: from [87.69.77.57] (port=2985 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6WPI-00034H-Lm; Sun, 09 Jan 2022 06:30:43 -0500 In-Reply-To: <8335lx2npc.fsf@gnu.org> (message from Eli Zaretskii on Sun, 09 Jan 2022 12:44:15 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223841 Archived-At: > Date: Sun, 09 Jan 2022 12:44:15 +0200 > From: Eli Zaretskii > Cc: 53133@debbugs.gnu.org > > > --- tabulated-list.el.org 2022-01-06 22:32:13.936852142 +0900 > > +++ tabulated-list.el 2022-01-07 15:15:42.000000000 +0900 > > @@ -574,7 +581,8 @@ > > (when not-last-col > > (when (> pad-right 0) (insert (make-string pad-right ?\s))) > > (insert (propertize > > - (make-string (- width (min width label-width)) ?\s) > > + ;; We need at least one space to align correctly. > > + (make-string (- width (min 1 width label-width)) ?\s) > > 'display `(space :align-to ,next-x)))) > > (put-text-property opoint (point) 'tabulated-list-column-name name) > > next-x))) > > You are right. > > Stefan, I reverted that change and I'm reopening bug#48639. This > problem is a much more serious regression than what happens sometimes > when text-size is scaled. We will need to find another fix for that > bug, most probably in one of the hooks used by tabulated-list.el, by > adding the display property only when actually needed. To help debugging the original problem: the 'display' property that was always present caused move-to-column in tabulated-list-print to stop at the wrong position, where the tabulated-list-column-name property had the wrong value. So either the 'display' property should be used only when actually needed, or the tabulated-list-column-name property should be also put on the text covered by the 'display' property.