From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#53242: [PATCH] unify reads from local_var_alist Date: Fri, 14 Jan 2022 10:08:49 +0200 Message-ID: <83zgny20z2.fsf@gnu.org> References: <50d65dbc-f3d6-86fb-6a7c-9200a6525ec2@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5281"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53242@debbugs.gnu.org To: Sergey Vinokurov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 14 09:17:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8Hls-00018A-NT for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Jan 2022 09:17:16 +0100 Original-Received: from localhost ([::1]:45268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8Hlr-0003MC-BF for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Jan 2022 03:17:15 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:32922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8Hey-00060t-7J for bug-gnu-emacs@gnu.org; Fri, 14 Jan 2022 03:10:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42494) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8Hes-0000yY-Pc for bug-gnu-emacs@gnu.org; Fri, 14 Jan 2022 03:10:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n8Hes-00048o-KY for bug-gnu-emacs@gnu.org; Fri, 14 Jan 2022 03:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Jan 2022 08:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53242 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53242-submit@debbugs.gnu.org id=B53242.164214774715816 (code B ref 53242); Fri, 14 Jan 2022 08:10:02 +0000 Original-Received: (at 53242) by debbugs.gnu.org; 14 Jan 2022 08:09:07 +0000 Original-Received: from localhost ([127.0.0.1]:35393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8Hdz-000472-H2 for submit@debbugs.gnu.org; Fri, 14 Jan 2022 03:09:07 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8Hdu-00046S-6U for 53242@debbugs.gnu.org; Fri, 14 Jan 2022 03:09:06 -0500 Original-Received: from [2001:470:142:3::e] (port=36024 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8Hdo-0000u4-WE; Fri, 14 Jan 2022 03:08:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Z3jA4VYJxvCBUPZk7hZ/bwyZfFGUHUNpxbPcfUhbqPM=; b=r3xGL9YI+bjL L8SaoEv/e4D+DkbmRxMdAkqaS+HdeWYXeL8j+pHdkdUbYcnZeRCe640Zc+wIdrRNyy+EBzJ63oG6t NDHEdIiOKtku7iCscfoxyTwBXPiAaYVGQvc67/AJuxabiIb2QgtNnDigWbRQS7DAlxGCgKHEEBDcs LC2GeEJdfhrg+mYBCJ+1u7886cdV2uPIyECj3bjUKLXeiZ8RSzNY8nFRFMdzwVutgw0B2VNZ7c6Ow SeljLKUUkd16kEUTEbqsAlBGYzMr7gzLEuLjT4NLnvCi0jl1aPLeYuqIOKkQN0gn4f9aFPRWxD8Vw qJzPVhaXb1KdRXiRcCiJGA==; Original-Received: from [87.69.77.57] (port=2091 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8Hdh-0005DV-QC; Fri, 14 Jan 2022 03:08:55 -0500 In-Reply-To: <50d65dbc-f3d6-86fb-6a7c-9200a6525ec2@gmail.com> (message from Sergey Vinokurov on Fri, 14 Jan 2022 00:23:42 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224159 Archived-At: > Date: Fri, 14 Jan 2022 00:23:42 +0000 > From: Sergey Vinokurov > > I've noticed that local_var_alist field of the buffer structure is > accessed inconsistently. Sometimes it's Fassoc, sometimes it's Fassq and > other times it's assq_no_quit and even an explicit loop. > > I think it's safe to unify all the accesses via assq_no_quit since it's > an internaly maintained alist that definitely has no cycles and elements > are cons cells with symbol as their car. How long can local_var_alist be? This change will not allow the user to C-g from a long search. Do we care? How about using Fassq consistently instead?