From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55153: 29.0.50; Implement system_process_attributes on Cygwin Date: Wed, 27 Apr 2022 18:52:58 +0300 Message-ID: <83zgk6bk11.fsf@gnu.org> References: <96920ef8-e5c6-0b9f-a8f4-b7e0b1c53328@cornell.edu> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20145"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55153@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 27 17:54:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njjzW-00050v-5A for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Apr 2022 17:54:10 +0200 Original-Received: from localhost ([::1]:35004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njjzV-0001JT-6C for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Apr 2022 11:54:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njjzO-0001JG-22 for bug-gnu-emacs@gnu.org; Wed, 27 Apr 2022 11:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50093) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njjzN-000475-Pk for bug-gnu-emacs@gnu.org; Wed, 27 Apr 2022 11:54:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1njjzN-00021p-Lt for bug-gnu-emacs@gnu.org; Wed, 27 Apr 2022 11:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Apr 2022 15:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55153 X-GNU-PR-Package: emacs Original-Received: via spool by 55153-submit@debbugs.gnu.org id=B55153.16510747957736 (code B ref 55153); Wed, 27 Apr 2022 15:54:01 +0000 Original-Received: (at 55153) by debbugs.gnu.org; 27 Apr 2022 15:53:15 +0000 Original-Received: from localhost ([127.0.0.1]:43990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njjyd-00020i-Jg for submit@debbugs.gnu.org; Wed, 27 Apr 2022 11:53:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njjyb-00020S-Ru for 55153@debbugs.gnu.org; Wed, 27 Apr 2022 11:53:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58234) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njjyW-00043J-8M; Wed, 27 Apr 2022 11:53:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=X0hvyek7qgqZvSViI88iDL06OT5KfyGiUd7DpPSYvMw=; b=grzPNGOoOU+Y qUFG7M4oZQ3glcKn+lm8NiVlQFyQ+d9SDZKHmBR2BuzaSSRsWB7BkToAYZF+Bbinkd9XEjSs64EHW d7gYXAOwY3nw2U4dxLd47eCQAMizcgU76rlKcvOaxNANOAMvDasURmzfaTmS4Sp3iSvYk7MmQ/kpG QJCaA6lmtuo7S7njpse1Gdgzlfeltq66eXUb5739dSx+sFQJ2WR9alh+N7yXxNBXOFrvIYWM5SUcV yCM+piu45hDLoSaK+7L3WoCVzv+Bcz0B558t/aQ1Sr7bH6+VHhuA+DFTwMXu9l61Hfx+AeOK9N6LV R8rXQE35qznhwIZJTDUBBQ==; Original-Received: from [87.69.77.57] (port=1559 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njjyV-0004iu-Ma; Wed, 27 Apr 2022 11:53:08 -0400 In-Reply-To: <96920ef8-e5c6-0b9f-a8f4-b7e0b1c53328@cornell.edu> (message from Ken Brown on Wed, 27 Apr 2022 11:16:46 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230795 Archived-At: > Date: Wed, 27 Apr 2022 11:16:46 -0400 > From: Ken Brown > > +# ifdef CYGWIN > + /* ttname */ > + strcpy (procfn_end, "/ctty"); > + fd = emacs_open (fn, O_RDONLY, 0); > + if (fd < 0) > + nread = 0; > + else > + { > + record_unwind_protect_int (close_file_unwind, fd); > + nread = emacs_read_quit (fd, procbuf, sizeof procbuf); > + } > + /* /proc//ctty should always end in newline. */ > + if (0 < nread && procbuf[nread - 1] == '\n') > + procbuf[nread - 1] = '\0'; > + else > + procbuf[0] = '\0'; > + attrs = Fcons (Fcons (Qttname, build_string (procbuf)), attrs); Is what you read from /proc//ctty guaranteed to be pure-ASCII string? If not, build_string is not the best idea here; you need to produce a unibyte string and decode it. Thanks. P.S. Doesn't this warrant a NEWS entry?