From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55370: [PATCH] Add support for the Syloti Nagri script Date: Sun, 15 May 2022 09:16:10 +0300 Message-ID: <83zgjjjp79.fsf@gnu.org> References: <83wnerp6p0.fsf@gnu.org> <83bkw2q28v.fsf@gnu.org> <837d6qpvdo.fsf@gnu.org> <831qwyptr7.fsf@gnu.org> <83sfpeoe81.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31843"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55370@debbugs.gnu.org To: =?UTF-8?Q?=E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0_?= =?UTF-8?Q?=E0=A4=B8=E0=A4=BF=E0=A4=82=E0=A4=B9?= Sameer Singh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 15 08:17:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nq7Z8-00084N-5L for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 15 May 2022 08:17:18 +0200 Original-Received: from localhost ([::1]:56454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nq7Z7-00087K-6K for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 15 May 2022 02:17:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54068) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nq7Yt-00087A-2n for bug-gnu-emacs@gnu.org; Sun, 15 May 2022 02:17:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54506) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nq7Ys-0001nD-HJ for bug-gnu-emacs@gnu.org; Sun, 15 May 2022 02:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nq7Ys-00066W-93 for bug-gnu-emacs@gnu.org; Sun, 15 May 2022 02:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 May 2022 06:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55370 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55370-submit@debbugs.gnu.org id=B55370.165259539323425 (code B ref 55370); Sun, 15 May 2022 06:17:02 +0000 Original-Received: (at 55370) by debbugs.gnu.org; 15 May 2022 06:16:33 +0000 Original-Received: from localhost ([127.0.0.1]:48403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nq7YP-00065l-4n for submit@debbugs.gnu.org; Sun, 15 May 2022 02:16:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nq7YN-00065U-Mj for 55370@debbugs.gnu.org; Sun, 15 May 2022 02:16:32 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43388) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nq7YI-0001le-BU; Sun, 15 May 2022 02:16:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=8JVcLEvTtb9SIcyUYF9lF6jr1OUkxVmivLW61Y3JVgY=; b=Bi+FQD+ZVrFD5aP+iRKT j5AlFI/9rW0hnxSNmyEn2hQP3sR44o5cEJGoxNi7eZk92yxE3bzd64FU6uJDikQVI1igkOzbK7/Vh usuALUvfu6PbJuDvVArgNfO7MuV/27jkgZy3eVqOtibtoIdYfDwq3RQ45zBJPR5IssfdsYOXBD9tC tpc6Au81nd5aKxN2cXcMU3IPoyIuOaPE6YvjKix5JJZUPjw91xaAzCApdkOb3ERVPmfOPmaCw7+UG DLX+Yd7vxGUOKAaCrZYDScpNLF9B6pnP27hvKVvKd6ox1f8wPDXRDCopC6rTN5n1KXQQVLTJOyWVs RncIUPatuCzwpg==; Original-Received: from [87.69.77.57] (port=1786 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nq7YH-0006d6-7F; Sun, 15 May 2022 02:16:25 -0400 In-Reply-To: (message from =?UTF-8?Q?=E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0_?= =?UTF-8?Q?=E0=A4=B8=E0=A4=BF=E0=A4=82=E0=A4=B9?= Sameer Singh on Sun, 15 May 2022 05:17:07 +0530) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:232279 Archived-At: > From: समीर सिंह Sameer Singh > Date: Sun, 15 May 2022 05:17:07 +0530 > Cc: 55370@debbugs.gnu.org > > I have updated the patch. > > 1. Wherever the nasal signs are not in range, I have not included them in a composition rule if they appear > alone with a character and left them up to composite.el. > For eg in Kaithi > > - ;; Nasal vowels > - (concat independent-vowel nasal "?") > + ;; Vowel based syllables > + (concat independent-vowel nukta "?" virama "?" vowel "?") > > 2. I have also written composition rules for independent vowels with nukta, virama, vowel signs etc, so that > Emacs does not hang when they are typed together. > > Please review the patch. Thanks. I installed this, but please review the composition rules, because in the Syloti Nagri greeting some characters whose Unicode general-category property is Mn, which means they are combining characters, don't compose. That doesn't feel right to me, but I don't read this script. Just go through the greeting with C-f and type "C-u C-x =" at every cursor position: you will see some of the characters are shown as "combining", but they don't compose with surrounding characters. I didn't look at the other scripts you added, but maybe they, too, have similar problems.