From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56682: Fix the long lines font locking related slowdowns Date: Sat, 30 Jul 2022 21:34:44 +0300 Message-ID: <83zggq4fgb.fsf@gnu.org> References: <8a3eaeef010995a5da8d@heytings.org> <837d40ds09.fsf@gnu.org> <83zggwcby5.fsf@gnu.org> <83o7xccagi.fsf@gnu.org> <831qu7daxb.fsf@gnu.org> <83sfmnb7yg.fsf@gnu.org> <837d3ybh5z.fsf@gnu.org> <136c4fe0fc74196714aa@heytings.org> <83pmhp89ov.fsf@gnu.org> <136c4fe0fc39573addc9@heytings.org> <83k07x8738.fsf@gnu.org> <136c4fe0fcdf00ef9a11@heytings.org> <83h73183r7.fsf@gnu.org> <136c4fe0fc0fceb0d752@heytings.org> <838roc8ka7.fsf@gnu.org> <83tu706obt.fsf@gnu.org> <83h7306ifa.fsf@gnu.org> <83edy37pul.fsf@gnu.org> <83pmhn55sk.fsf@gnu.org> <65cb7c73fdc753518d35@heytings.org> <83fsii68o3.fsf@gnu.org> <65cb7c73fdf6704d19d5@heytings.org> <835yje62vz.fsf@gnu.org> <65cb7c73fd159efe32af@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2597"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, 56682@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 30 20:36:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oHrK5-0000Up-5P for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Jul 2022 20:36:25 +0200 Original-Received: from localhost ([::1]:51978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oHrK3-0007PO-MR for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Jul 2022 14:36:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51420) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHrJi-0007PF-VF for bug-gnu-emacs@gnu.org; Sat, 30 Jul 2022 14:36:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46002) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oHrJh-0004bX-Mm for bug-gnu-emacs@gnu.org; Sat, 30 Jul 2022 14:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oHrJh-0000Bg-J1 for bug-gnu-emacs@gnu.org; Sat, 30 Jul 2022 14:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Jul 2022 18:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.1659206109625 (code B ref 56682); Sat, 30 Jul 2022 18:36:01 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 30 Jul 2022 18:35:09 +0000 Original-Received: from localhost ([127.0.0.1]:35751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oHrIq-0000A1-IQ for submit@debbugs.gnu.org; Sat, 30 Jul 2022 14:35:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oHrIn-00009Q-Jq for 56682@debbugs.gnu.org; Sat, 30 Jul 2022 14:35:07 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40026) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHrIg-0004H8-Oo; Sat, 30 Jul 2022 14:34:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=NGxtrr0spQL1Uu8p1i0BmQCKXWmxhiJji++gybniYQ4=; b=VnzzCzZwRn5H 5P63hX2jwKIeqyLjWPlJLe5/yAeXd5kmwrd9cPttKVJaDzdx8OR5dv05yi7lAoONzNvT5MU9QV0gO qav8Zf8wr6UTKNKU2vNOr+tgyvW+n9uGWUicxI0E47xr9VAOVFEXtvLEOPgYtAXaphOTTpyALMttE Y4u44tE4AwB9ePDddRoSSh19pGMXhBYTlhLU9CKuICsoCtXvHWPDij4+gk+sJ8+4iYHRl2Gn17N23 zf9worux1oLBi5kBKstPwK4Bz0XxWO4E/2bvlyi7Z0bnUsrs0ZwMa1RmD99sPl2PS1B7aJDc1oM9s eFNhsfgMkPOFlN6IRu44sA==; Original-Received: from [87.69.77.57] (port=4307 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHrIg-0007Dl-8O; Sat, 30 Jul 2022 14:34:58 -0400 In-Reply-To: <65cb7c73fd159efe32af@heytings.org> (message from Gregory Heytings on Sat, 30 Jul 2022 18:13:18 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238307 Archived-At: > Date: Sat, 30 Jul 2022 18:13:18 +0000 > From: Gregory Heytings > cc: gerd.moellmann@gmail.com, 56682@debbugs.gnu.org, larsi@gnus.org, > monnier@iro.umontreal.ca > > Wouldn't it make sense to also limit the portion of the buffer to which > pre-/post-command-hook have access (see below)? Those generally don't belong to the display department, so I'd hesitate doing so. Which pre-/post-command-hook functions did you find that cause slowdown because of long lines. Before considering these hooks, I'd consider window-scroll-functions and window-*-change-functions, which _are_ run by redisplay. > With that patch, I was able to open and edit a file with a single 50 GB > (!) line, in js-mode. Does that still not qualify as "arbitrarily large"? We don't even claim to be able to edit _files_ of arbitrary size (because we are limited by fixnums). > I compared that with a 50 GB JSON file with 80 character wide lines. > With that file it was necessary to disable font-lock-mode, which took too > much time. How so? We now restrict font-lock to a small region, so why does it matter how much more stuff is there outside of the viewport? What other aspects of the line size still affect performance?