From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Date: Wed, 02 Nov 2022 22:09:21 +0200 Message-ID: <83zgd986fi.fsf@gnu.org> References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> <835yfx9p0z.fsf@gnu.org> <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> <831qql9n4s.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26639"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58909@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 02 21:10:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqK47-0006gn-3t for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Nov 2022 21:10:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqK3p-0002Su-4J; Wed, 02 Nov 2022 16:10:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqK3n-0002SL-J7 for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 16:10:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oqK3m-00072o-Vl for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 16:10:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oqK3m-0002Ql-69 for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 16:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2022 20:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.16674197789309 (code B ref 58909); Wed, 02 Nov 2022 20:10:02 +0000 Original-Received: (at 58909) by debbugs.gnu.org; 2 Nov 2022 20:09:38 +0000 Original-Received: from localhost ([127.0.0.1]:47233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqK3O-0002Q4-96 for submit@debbugs.gnu.org; Wed, 02 Nov 2022 16:09:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqK3M-0002Ps-GJ for 58909@debbugs.gnu.org; Wed, 02 Nov 2022 16:09:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqK3H-000710-3l; Wed, 02 Nov 2022 16:09:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2sw2JucS+x8Hwe2bj7LXmohDjOL3C3RChC+FV4rYl8M=; b=gOKZJFZUtdLR ycfu8EH3Oq9WHM2EcpPTUtuvO29GuPDGaGZze5ofsb5HnOriQUdpLevm/bLuOhqn684EheHSKiP1V Nl/VhZXZ5y+BykxJjXujm7C25LQKZKvCmzdbydEcIFgdLekbDAkW1hWcKI71eQOfVLYD42OKJWabg 4oykJD3J2CYzCnBj1yxJRenOMYvTTxXehb/g7gTEa9RbiS1CxyfVqehi7+zgeI2Vag7E7lgefSR0y Km6cuEWuxSsvycjKevF3j1NOo+JKN7NCCj5R8r3YAGPruWSQfLVp7A5Z2ofC3zpQuvbj6kwrqlsvo ZmyXAu+eFdQ5QkOrVKVelw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqK3G-0000xU-K0; Wed, 02 Nov 2022 16:09:30 -0400 In-Reply-To: (message from Jim Porter on Wed, 2 Nov 2022 12:57:57 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246892 Archived-At: > Date: Wed, 2 Nov 2022 12:57:57 -0700 > Cc: 58909@debbugs.gnu.org > From: Jim Porter > > On 11/2/2022 12:23 PM, Eli Zaretskii wrote: > > Isn't the last suggestion, of having an optional prompt in > > server-delete-client, good enough? > > 'server-delete-client' is called in a bunch of spots, so at minimum, I'd > want to be extra-careful that prompting doesn't break one of those > cases. Sorry, I meant server-handle-delete-frame. > It would also be nice if I could fix the C-g issue, at least in my > local configuration. You could rebind "C-x 5 0" to a different command, and do whatever you want there. > Still, I'll take a look at doing this if you think it would be good to > add to Emacs. (If you think it's not needed, I really don't mind leaving > the code as-is.) I thought my opinions on this were clear from the very beginning... > >> If starting the server activates a minor mode, then Emacs can use a > >> minor-mode keymap for server-mode. [snip] > > > > I'm fine with doing that, but we must also make sure this mode is > > turned on when users invoke server-start interactively. > > I think that makes sense, and it should be fairly straightforward. I'll > work on a patch for this. Thanks.