From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows Date: Fri, 18 Nov 2022 16:35:05 +0200 Message-ID: <83zgco9vqe.fsf@gnu.org> References: <86bkp5y16y.fsf@gnu.org> <83r0y1cxyb.fsf@gnu.org> <87o7t5wlby.fsf@gmail.com> <87bkp5xl6f.fsf@dfreeman.email> <87fsehw4ze.fsf@gmail.com> <83cz9kd99x.fsf@gnu.org> <87wn7swf4e.fsf@dfreeman.email> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1943"; mail-complaints-to="usenet@ciao.gmane.io" Cc: arash@gnu.org, arstoffel@gmail.com, 59338@debbugs.gnu.org To: Danny Freeman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 18 15:36:39 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ow2Tv-0000Ha-CO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Nov 2022 15:36:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ow2TU-0004rL-Bo; Fri, 18 Nov 2022 09:36:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow2TK-0004qp-WD for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 09:36:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ow2TK-0003qt-Iy for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 09:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ow2TK-0001GD-DT for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 09:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Nov 2022 14:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59338 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: arash@gnu.org, arstoffel@gmail.com, bug-gnu-emacs@gnu.org, 59338@debbugs.gnu.org Original-Received: via spool by 59338-submit@debbugs.gnu.org id=B59338.16687821114778 (code B ref 59338); Fri, 18 Nov 2022 14:36:02 +0000 Original-Received: (at 59338) by debbugs.gnu.org; 18 Nov 2022 14:35:11 +0000 Original-Received: from localhost ([127.0.0.1]:35963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow2SV-0001Ez-Db for submit@debbugs.gnu.org; Fri, 18 Nov 2022 09:35:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow2ST-0001EY-Dq for 59338@debbugs.gnu.org; Fri, 18 Nov 2022 09:35:09 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow2SO-0003aI-09; Fri, 18 Nov 2022 09:35:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=loIIogpumYKDilbtWfHJE0TmXpuXYgVawVusbkh1rdg=; b=ehLjR8BF33IF WKo2vVlC8Z5zk0f0NhkMp12v5bvktRjLul37e0KJfR0KwXP3pvdluJDsgR5GpZ+BfQpUhwKyRPgpK uH83yMaBrsGudODr2FRpq/F8u5GYCL1qdzbRdWyy/8aDiDE9HMU3+PMbWOxLlSscnzL40h4ztLzhF G7x716cWv32yPJW85hyNwWbDgIuhtDirG4ndgyNyFQ/Bi7CGlVWpH7HMueQq5AVTzTtz0GU2QMzA3 LTfQ7cRQsXgMw5VF4mFubKrju+i8odj5OWEaDNbQAV3KewOTYnqADkwvTOw/50RouI8azyiVKtF07 hZqlpqsifJAOAOu7/Pcf3Q==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow2SM-0003vP-R7; Fri, 18 Nov 2022 09:35:03 -0500 In-Reply-To: <87wn7swf4e.fsf@dfreeman.email> (message from Danny Freeman on Fri, 18 Nov 2022 08:39:13 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248246 Archived-At: > From: Danny Freeman > Cc: Augusto Stoffel , arash@gnu.org, > 59338@debbugs.gnu.org, bug-gnu-emacs@gnu.org > Date: Fri, 18 Nov 2022 08:39:13 -0500 > > The current eglot--path-to-uri implementation should produce a valid > file:// url unless what it receives is already a URL. > > So it could receive something like: > > /home/user/project/whatever.c > d:/what/home/is/on/windows/whatever.c > > Both of which should be transformed into file:// URLs > OR what it receives may already be a URL like > > zipfile:home/user/project.zip::/path/in/zip.c > > If it receives a URL, we want to pass it along, and not transform it > into a file:// URL. > > If it is a full windows path, we DO want to turn that into a file url. > > So how do we detect that is is a windows path, and not a URL already? You test that system-type is windows-nt AND that the file-name-absolute-p returns non-nil for the argument.